Skip to content

Enable binary custom rules#1718

Closed
rjmholt wants to merge 2 commits into
PowerShell:masterfrom
rjmholt:enable-binary-rules
Closed

Enable binary custom rules#1718
rjmholt wants to merge 2 commits into
PowerShell:masterfrom
rjmholt:enable-binary-rules

Conversation

@rjmholt
Copy link
Copy Markdown
Contributor

@rjmholt rjmholt commented Sep 24, 2021

PR Summary

Looking through the code, most of the existing code was already there to support this. So I've just hooked up the final piece.

PR Checklist

@bergmeister
Copy link
Copy Markdown
Collaborator

Not too surprising, I remember this comment from the previous maintainer: #765 (comment)
In the first instance, if getting it to work is that simple, then I'd say writing an automated test could even be deferred to another PR as I can understand this would be more involving, especially since Ps Core cannot unload loaded DLLs easily

@rjmholt
Copy link
Copy Markdown
Contributor Author

rjmholt commented Oct 26, 2021

For an example of how to implement a binary rule with this change, see this gist

@rjmholt rjmholt closed this Jan 7, 2022
@bergmeister
Copy link
Copy Markdown
Collaborator

@rjmholt If this PR makes it work then I'd be happy to just merge it and we can raise a backlog item for writing a test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants