Fix broken links to old .md files, set correct root directory for Get-RuleDocumentationPath function

[fabge]

PR Summary

There were still links to the old "RuleDocumentation" folder and some files were renamed.
The root directory if the Get-RuleDocumentationPath function was also set to the "Rules" folder

PR Checklist

• PR has a meaningful title
  • Use the present tense and imperative mood when describing your changes
• Summarized changes
• Change is not breaking
• Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
• Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
• This PR is ready to merge and is not Work in Progress.
  • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

[ghost]

All CLA requirements met.

[andyleejordan]

Great catch! One more extension to fix (I think).

[rjmholt]

The new links here will link to the source code. Instead they should link to the rule documentation, which looks like it now lives under https://github.com/PowerShell/PSScriptAnalyzer/tree/master/docs/Rules

[andyleejordan]

Rob is right, the .cs are transformed into .md into the confusingly similarly named docs/Rules folder (instead of just Rules) found here: https://github.com/PowerShell/PSScriptAnalyzer/tree/master/docs/Rules

So, the links are still broken as-is, but the fix is different. Keep the .md extension, but point to docs/Rules/ instead of RuleDocumentation/ (or Rules/ as in this first iteration).

[rjmholt]

the confusingly similarly named docs/Rules folder

It used to be RulesDocumentation but #1724 changed this so all documentation is under one folder.

[fabge]

Thanks for the feedback. I pushed a new commit, changing the filepaths to the Markdown files under docs/Rules.
I couldn't find the corresponding Markdown file for the https://github.com/PowerShell/PSScriptAnalyzer/blob/master/Rules/AvoidAlias.cs rule. Any pointers if this is missing or does not exist?

[andyleejordan]

Thanks so much!

[andyleejordan]

Suggested change

	- Empty catch block should not be used [AvoidEmptyCatchBlock](https://github.com/PowerShell/PSScriptAnalyzer/blob/master/docs/Rules/AvoidUsingEmptyCatchBlock.md)
	- Empty catch block should not be used [AvoidUsingEmptyCatchBlock](https://github.com/PowerShell/PSScriptAnalyzer/blob/master/docs/Rules/AvoidUsingEmptyCatchBlock.md)

[andyleejordan]

Suggested change

	- Positional parameters should be avoided [AvoidPositionalParameters](https://github.com/PowerShell/PSScriptAnalyzer/blob/master/docs/Rules/AvoidUsingPositionalParameters.md)
	- Positional parameters should be avoided [AvoidUsingPositionalParameters](https://github.com/PowerShell/PSScriptAnalyzer/blob/master/docs/Rules/AvoidUsingPositionalParameters.md)

[andyleejordan]

Suggested change

	- Password = 'string' should not be used. (information disclosure) [AvoidUserNameAndPasswordParams](https://github.com/PowerShell/PSScriptAnalyzer/blob/master/docs/Rules/AvoidUsingUsernameAndPasswordParams.md)
	- Password = 'string' should not be used. (information disclosure) [AvoidUsingUserNameAndPasswordParams](https://github.com/PowerShell/PSScriptAnalyzer/blob/master/docs/Rules/AvoidUsingUsernameAndPasswordParams.md)

[andyleejordan]

Suggested change

	- Avoid using alias [AvoidAlias](https://github.com/PowerShell/PSScriptAnalyzer/blob/master/docs/Rules/AvoidAlias.md) #TODO not found
	- Avoid using cmdlet aliases [AvoidUsingCmdletAliases](https://github.com/PowerShell/PSScriptAnalyzer/blob/master/docs/Rules/AvoidUsingCmdletAliases.md)

I looked through the Git history and this was renamed in 11a04a9

[bergmeister]

LGTM, I resolved the merge conflict, please check you are happy with it. Can you give it a final review @sdwheeler and @andschwa please?

[sdwheeler]

Just a note about this article. This has been migrated to https://docs.microsoft.com/powershell/utility-modules/psscriptanalyzer/rules-recommendations. It is scheduled to be deleted from the source repo in a month.

[fabge]

Guys, can you either merge or reject? I'd like this closed...

[andyleejordan]

@SydneyhSmith and @JamesWTruher we need to triage / merge this!

[bergmeister]

To me it sounds like we can close it since it's moved to an upstream source and the files here will vanish soon. Do you agree @sdwheeler ?

[sdwheeler]

@bergmeister I agree. However, there is still the change to Utils/RuleMaker.psm1 that needs to be made. If we merge this then we get that change. The other doc will be delete in a month so the changes to it can be merged as is. The doc is already published to the live site at https://docs.microsoft.com/powershell/utility-modules/psscriptanalyzer/rules-recommendations. So the broken links are not an issue.