Skip to content

Add foreach Assignment to AvoidAssignmentToAutomaticVariable #2021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andyleejordan merged 5 commits into from
Feb 25, 2025
Merged

Add foreach Assignment to AvoidAssignmentToAutomaticVariable #2021

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ca86fd0
Add Evaluation for foreach Assignment
Aug 10, 2024
8b9bd22
Add Tests for foreach Assignment
Aug 10, 2024
0d1d917
Update Tests for Consistency
Aug 10, 2024
2360fb5
Remove Unnecessary ExcludeRule
Aug 10, 2024
7cf4013
Update Test Description
Aug 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove Unnecessary ExcludeRule
  • Loading branch information
@poshAJ
PoshAJ authored and poshAJ committed Feb 24, 2025
commit 2360fb50b14645bad3b0dd7848e255da5d0c10fb
2 changes: 1 addition & 1 deletion Tests/Rules/AvoidAssignmentToAutomaticVariable.tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ Describe "AvoidAssignmentToAutomaticVariables" {
It "Using Variable <VariableName> as foreach name produces warning of Severity <ExpectedSeverity>" -TestCases $testCases_AutomaticVariables {
param ($VariableName, $ExpectedSeverity)

[System.Array] $warnings = Invoke-ScriptAnalyzer -ScriptDefinition "foreach (`$$VariableName in `$foo) {}" -ExcludeRule PSReviewUnusedParameter
[System.Array] $warnings = Invoke-ScriptAnalyzer -ScriptDefinition "foreach (`$$VariableName in `$foo) {}"
$warnings.Count | Should -Be 1
$warnings.Severity | Should -Be $ExpectedSeverity
$warnings.RuleName | Should -Be $ruleName
Expand Down