Drop v3 and v4 support from build

[andyleejordan]

This leaves all the guarded v3 and v4 implementation and test code, but starts the removal of support by dropping it from the build and updating the manifest.

[SeeminglyScience]

LGTM!

[bergmeister]

There is also lots of conditional code in C# around PSV3/PSV4 and around PowerShell version in Pester tests. Plus the build scripts that package things up for each version.
I was thinking maybe start softer and only bump the minimum version in the manifest for now and wait for feedback following release, this way we wouldn't completely block people because they could just manually edit the manifest

[andyleejordan]

There is also lots of conditional code in C# around PSV3/PSV4 and around PowerShell version in Pester tests. Plus the build scripts that package things up for each version. I was thinking maybe start softer and only bump the minimum version in the manifest for now and wait for feedback following release, this way we wouldn't completely block people because they could just manually edit the manifest

Yes indeed. I'll cut this down a bit to start.

[andyleejordan]

@bergmeister looking at it with a fresh set of eyes I'm thinking this is a good minimal start. It's in Git so we can bring it all back if needed, but essentially it covers the build and packaging process without touching the code and tests.

[bergmeister]

@bergmeister looking at it with a fresh set of eyes I'm thinking this is a good minimal start. It's in Git so we can bring it all back if needed, but essentially it covers the build and packaging process without touching the code and tests.

Ok, I was more thinking from an end user perspective because if binaries are missing in new release, there is no hack to still be able to use it. But there is no right and wrong, just a question of speed of change and how many eggs to crack for the omelette in one go