Add macos detection to New-CommandDataFile#947
Merged
bergmeister merged 2 commits intoPowerShell:developmentfrom Mar 27, 2018
GavinEke:development
Merged
Add macos detection to New-CommandDataFile#947bergmeister merged 2 commits intoPowerShell:developmentfrom GavinEke:development
bergmeister merged 2 commits intoPowerShell:developmentfrom
GavinEke:development
Conversation
bergmeister
approved these changes
Mar 26, 2018
Collaborator
bergmeister
left a comment
There was a problem hiding this comment.
Thanks for contributing. The change makes sense to me. But I do not see the need to support old Beta versions of PowerShell Core, therefore I removed the elseif ($IsOSX) block. Otherwise looks good to me. I tend to keep PRs open for at least 24h for visibility to others and will merge it then if there are no objections from others.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Add MacOS Detection as
$osin PSCore v6.0.0-beta.7 and higher are getting incorrectly set aswindowsin the Get-CmdletDataFileName functionMore details: https://github.com/PowerShell/PowerShell/blob/master/docs/BREAKINGCHANGES.md#rename-isosx-to-ismacos-4700
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets. Please mark anything not applicable to this PRNA.WIP:to the beginning of the title and remove the prefix when the PR is ready