Send stopDebugger notification when appropriate#1570
Merged
andyleejordan merged 3 commits intomasterfrom Sep 7, 2021
Merged
Conversation
andyleejordan
force-pushed
the
andschwa/stop-debugger
branch
from
92ae819 to
69f4be6
Compare
Member
Author
|
This needs some tests... |
andyleejordan
added
Area-Debugging
Issue-Enhancement
I added a bunch more recently that was became less useful and more noisy after my familiarity improved.
andyleejordan
force-pushed
the
andschwa/stop-debugger
branch
from
69f4be6 to
1b362fb
Compare
rjmholt
approved these changes
Sep 3, 2021
Member
Author
|
I'm going to merge so as to get it into a preview while I work on tests. |
5 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the edge case where the debug server is running because it was started by PowerShell (and not by an LSP event), and we're no longer in the debugger within PowerShell, so since we own the state we need to stop the debug server too.
Along with PowerShell/vscode-powershell#3542, this resolves one of the main issues brought up in PowerShell/vscode-powershell#3522.