Fix testing for pipeline consumer branch#1588
Fix testing for pipeline consumer branch#1588rjmholt merged 17 commits intoPowerShell:async-ps-consumerfrom
Conversation
|
(Had to mark this as ready for review to run CI) |
|
Where are our tests?? |
|
Not yet able to reproduce the test hangs locally: |
|
Interesting that it's just macOS and Ubuntu now. |
| _pipelineThread.SetApartmentState(ApartmentState.STA); | ||
| if (VersionUtils.IsWindows) | ||
| { | ||
| _pipelineThread.SetApartmentState(ApartmentState.STA); |
|
We're passing now! I have disabled the LSP unit tests, but I think those should be re-enabled in a different PR since they'll represent a fair amount more work. |
andyleejordan
left a comment
andyleejordan
left a comment
There was a problem hiding this comment.
Just double-checking that all of these disabled tests are intentionally disabled, since many of them are not LSP unit tests (unless I misread).
| var factory = new LoggerFactory(); | ||
| _psesProcess = new PsesStdioProcess(factory, IsDebugAdapterTests); | ||
| await _psesProcess.Start().ConfigureAwait(false); | ||
| //Debugger.Launch(); |
|
|
||
| namespace Microsoft.PowerShell.EditorServices.Test.Console | ||
| { | ||
| /* |
There was a problem hiding this comment.
This I think no longer exists and should be brought back maybe. See #1583
|
|
||
| namespace Microsoft.PowerShell.EditorServices.Test.Debugging | ||
| { | ||
| /* |
There was a problem hiding this comment.
Needs a host factory
|
|
||
| namespace Microsoft.PowerShell.EditorServices.Test.Console | ||
| { | ||
| /* |
There was a problem hiding this comment.
Yeah these need to be converted to something like host tests
| Assert.Equal(escapedPath, extensionEscapedPath); | ||
| } | ||
|
|
||
| [Trait("Category", "PathEscaping")] |
There was a problem hiding this comment.
Yeah these no longer apply because the method to test is gone
|
|
||
| namespace Microsoft.PowerShell.EditorServices.Test.Language | ||
| { | ||
| /* |
There was a problem hiding this comment.
Needs a host factory
2 participants
No description provided.