Avoid recording debugger commands in the history#1704
Merged
andyleejordan merged 1 commit intomasterfrom Feb 16, 2022
Merged
Conversation
Member
Author
|
The debugger commands haven't changed in eons (at least not since Sergei and I imported Source Depot to GitHub. I'd love to reference them directly but this super helpful class is marked |
Member
Author
|
Uh oh things are broken. |
Member
Author
|
Interesting... I actually wonder if this fixes a regression in the tests when we did the pipeline rewrite. |
andyleejordan
force-pushed
the
andschwa/debugger-commands
branch
2 times, most recently
from
1200f62 to
1e8804a
Compare
andyleejordan
commented
Feb 11, 2022
| const string newStrValue = "Goodbye"; | ||
| const string newStrValue = "\"Goodbye\""; | ||
| VariableScope localScope = Array.Find(scopes, s => s.Name == VariableContainerDetails.LocalScopeName); | ||
| // TODO: Fix this so it has the second quotes again? |
Member
Author
There was a problem hiding this comment.
The quotes are back!
Member
Author
|
Need to test with PowerShell 5.1. |
PaulHigin
approved these changes
Feb 16, 2022
andyleejordan
force-pushed
the
andschwa/debugger-commands
branch
from
1e8804a to
3cad765
Compare
This changes how we decide to run a given command through `ExecuteInDebugger` or `ExecuteNormally`. It now restricts the former such that it is only used for PowerShell's intrinsic debugger commands (like `s`, `c`, etc.) and the latter is used for any other user command or, more importantly, our own implementation's debugger commands (like when we call `Get-Variable`).
andyleejordan
force-pushed
the
andschwa/debugger-commands
branch
from
3cad765 to
a759b74
Compare
Member
Author
|
Ok @PaulHigin yes, it did need to be made case-insensitive. Fixed that. And I tested manually with Windows PowerShell 5.1, all still works as expected! |
Member
Author
|
Fixed most of PowerShell/vscode-powershell#873 and PowerShell/vscode-powershell#1265 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes how we decide to run a given command through
ExecuteInDebuggerorExecuteNormally. It now restricts the formersuch that it is only used for PowerShell's intrinsic debugger commands
(like
s,c, etc.) and the latter is used for any other user commandor, more importantly, our own implementation's debugger commands (like
when we call
Get-Variable).