Fix extra prompting and manual debugger commands#1778
Merged
andyleejordan merged 2 commits intomasterfrom Apr 27, 2022
Merged
Conversation
This requires that we set the REPL to exit correctly. Note that we don't have a notion of "disconnect" so we removed that logic. We are assuming the debugger is "active" a little earlier now, that is, also when we've received an LSP notification to start it (via a launch or attach handler). Because we receive a notification on "disconnect" even for a script just finishing, we need to know that the server is not active and so not cancel the current prompt.
This was referenced Apr 27, 2022
Member
Author
|
@SeeminglyScience Just added the commit that removes the |
Member
Author
|
Kind of funny cosmetic bug: if you run a script, and then type input at the next prompt, and then run the script again, then PSReadLine doesn't save that input. But if you've invoked anything else in between (or type that text before running the script) it works fine. Strange, we'll fix it later. |
SeeminglyScience
requested changes
Apr 27, 2022
Collaborator
SeeminglyScience
left a comment
There was a problem hiding this comment.
LGTM but one thing. HMU if you want to keep it, doing request changes to not trigger auto merge
src/PowerShellEditorServices/Services/PowerShell/Host/PsesInternalHost.cs
Outdated
Show resolved
Hide resolved
2eb92ae to
e968d8b
Compare
e968d8b to
3cba30c
Compare
SeeminglyScience
approved these changes
Apr 27, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This requires that we set the REPL to exit correctly. Note that we don't
have a notion of "disconnect" so we removed that logic. We are assuming
the debugger is "active" a little earlier now, that is, also when we've
received an LSP notification to start it (via a launch or attach
handler). Because we receive a notification on "disconnect" even for a
script just finishing, we need to know that the server is not active and
so not cancel the current prompt.