Merged
Conversation
andyleejordan
added
Issue-Enhancement
andyleejordan
force-pushed
the
andschwa/tests
branch
2 times, most recently
from
d08b0cc to
52e2455
Compare
JustinGrote
approved these changes
Jun 27, 2022
Collaborator
JustinGrote
left a comment
JustinGrote
left a comment
There was a problem hiding this comment.
Not in a place to run it right now but your logic looks sound to me.
Member
Author
|
🤞 these tests pass...seems just flaky as it works locally 😓 |
Member
Author
|
Well, seems to be a Windows issue now. Maybe because old Pester versions in-box? |
andyleejordan
force-pushed
the
andschwa/tests
branch
from
52e2455 to
4bb9108
Compare
andyleejordan
force-pushed
the
andschwa/tests
branch
19 times, most recently
from
5bef806 to
d483736
Compare
andyleejordan
force-pushed
the
andschwa/tests
branch
2 times, most recently
from
f5b370a to
c274c94
Compare
andyleejordan
force-pushed
the
andschwa/tests
branch
from
c274c94 to
ba30996
Compare
Member
Author
|
Ok, I give up, skipping on Windows. @SeeminglyScience please review! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I couldn't actually get #1672 to repro, but I did add a comprehensive end-to-end test for running a Pester test file.