Map new powershell.codeFormatting settings for new options in PSSA 1.18: WhitespaceInsideBrace and WhitespaceAroundPipe#835
Merged
TylerLeonhardt merged 2 commits intoPowerShell:masterfrom Mar 20, 2019
Conversation
…WhitespaceAroundPipe to PSSA settings hash table
4 tasks
…orServices into PSSA_CheckInnerBraceAndPipe
Contributor
Author
|
The depending PSSA PR has been merged now (meaning the feature will be in 1.18), so only the release is blocking the PR from merging, can you please start the review @TylerLeonhardt or @rjmholt in the meantime? |
rjmholt
changed the title
rjmholt
approved these changes
Mar 5, 2019
bergmeister
pushed a commit
to bergmeister/PowerShellEditorServices
that referenced
this pull request
Mar 20, 2019
…WhitespaceAroundPipe to PSSA settings hash table (PowerShell#835)
TylerLeonhardt
added a commit
that referenced
this pull request
Mar 21, 2019
…WhitespaceAroundPipe to PSSA settings hash table (#835)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR can only be merged once PSSA 1.18 has released
This wires up new PSSA settings from this PR with new vscode-powershell settings here