Skip to content

Replace smarty condition "else if" by "elseif"#142

Merged
SharakPL merged 2 commits intoPrestaShop:developfrom
Klemart3D:develop
Mar 7, 2024
Merged

Replace smarty condition "else if" by "elseif"#142
SharakPL merged 2 commits intoPrestaShop:developfrom
Klemart3D:develop

Conversation

@Klemart3D
Copy link
Contributor

@Klemart3D Klemart3D commented Mar 1, 2024

Questions Answers
Description? Replace smarty condition "else if" by "elseif" following official doc
Type? refactor
BC breaks? no
Deprecations? no
Fixed ticket? Partially #604 (must be also applied into Humminbird theme & modules)
Sponsor company Your company or customer's name goes here (if applicable).
How to test? Search for "{else if" in whole .tpl files, there must be "0 results"

@Klemart3D
Copy link
Contributor Author

Klemart3D commented Mar 1, 2024

Pull request also made for Hummingbird theme : PrestaShop/hummingbird#605

Copy link
Contributor

@SharakPL SharakPL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Klemart3D and thanks for your PRs.
It's a really old doc you referenced there 😉 But in this part it's still valid in Smarty v.4 currently used in Prestashop so good job. Thank you 👍

@ps-jarvis ps-jarvis added the Waiting for QA Status: Waiting for QA feedback label Mar 2, 2024
@SharakPL SharakPL added this to the 2.1.4 milestone Mar 6, 2024
@kpodemski kpodemski modified the milestones: 2.1.4, 3.0.0 Mar 7, 2024
@florine2623 florine2623 self-assigned this Mar 7, 2024
Copy link

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Klemart3D ,

LGTM ✅
classic theme on product page and contact page are well displayed.

Thanks!

@florine2623 florine2623 added QA ✔️ Status: QA-Approved and removed Waiting for QA Status: Waiting for QA feedback labels Mar 7, 2024
@SharakPL SharakPL merged commit 90a2a88 into PrestaShop:develop Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

QA ✔️ Status: QA-Approved

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants