Class h4 for h1

[BenTen]

In hummingbird 1.0.1, we can see in templates/page.tpl

  {block name='page_header_container'}
    {block name='page_title'}
      <div class="page-header">
        <h1 class="h4">{$smarty.block.child}</h1>
      </div>
    {/block}
  {/block}

why h1 has a class h4? Just a miss during #524 or something I don't understand?

[tblivet]

Hi @BenTen, semantically we need an <h1> tag, but in terms of styling, Bootstrap provides .h1, .h2, .h3, .h4, etc., classes for visual purposes. In this case, we wanted an <h1> that renders like an <h4>. This pattern appears in various places throughout the theme.

[Hlavtox]

Exactly as @tblivet says

@BenTen https://getbootstrap.com/docs/5.3/content/typography/#headings

.h1 through .h6 classes are also available, for when you want to match the font styling of a heading but cannot use the associated HTML element.

[BenTen]

Right, so I closed the issue. Thank you for details.