Merged
Conversation
NeOMakinG
commented
Apr 4, 2022
NeOMakinG
commented
| Questions | Answers |
|---|---|
| Description? | We need to apply a some JS in order to show password policy tips |
| Type? | new feature |
| BC breaks? | no |
| Deprecations? | no |
| How to test? | Go on register as a customer, type your password and have fun! |
| Possible impacts? | Register as a customer |
PierreRambaud
approved these changes
Apr 5, 2022
mparvazi
reviewed
Apr 6, 2022
Member
|
|
Progi1984
previously requested changes
Apr 11, 2022
Member
Progi1984
left a comment
Progi1984
left a comment
There was a problem hiding this comment.
Could you remove merge commits ?
Author
|
I'll leave this as a draft and not fixing things until it's merged on the core side, it will avoid me dealing with rebases and whatever :) |
NeOMakinG
force-pushed
the
add-password-policy
branch
2 times, most recently
from
8471324 to
0e98319
Compare
Member
|
@NeOMakinG looks like there's a conflict 🙃 |
added 2 commits
December 6, 2022 15:24
fix: integrate password policy Json encode translations for password feedbacks Make sure data exists before using it Add correct configuration values fix: eslint Implement the score checker and fix: make template available everywhere Update package-lock Fix double import
NeOMakinG
force-pushed
the
add-password-policy
branch
from
df72638 to
1da4ada
Compare
Author
|
@Hlavtox considering mparvarsi's review and stuff, can you check and approve/merge if it looks fine for you? |
Author
|
@PrestaShop/prestashop-maintainers can I get a review from someone there? @Hlavtox told me that he was ready to merge it but I would like one more pair of eyes on it |
matthieu-rolland
approved these changes
Dec 13, 2022
Hlavtox
approved these changes
Dec 14, 2022
Contributor
|
Thanks @NeOMakinG 💋 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.