Switch some images to picture tags#403
Merged
SharakPL merged 4 commits intoPrestaShop:developfrom Dec 9, 2022
Merged
Conversation
NeOMakinG
commented
Dec 7, 2022
NeOMakinG
commented
| Questions | Answers |
|---|---|
| Description? | We want to use picture tags everywhere we have some images and these parts were missing |
| Type? | improvement |
| BC breaks? | no |
| Deprecations? | no |
| How to test? | Images on every part should work as expected |
| Possible impacts? | Images display |
Hlavtox
reviewed
Dec 7, 2022
Hlavtox
approved these changes
Dec 7, 2022
Contributor
Hlavtox
left a comment
Hlavtox
left a comment
There was a problem hiding this comment.
Just check the legends, good otherwise!
Author
Hlavtox
approved these changes
Dec 9, 2022
Contributor
|
@SharakPL Merge it when you check it ;-) |
SharakPL
approved these changes
Dec 9, 2022
Hlavtox
reviewed
Dec 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.