Preload material icons, allow to preload other fonts#427
Preload material icons, allow to preload other fonts#427kpodemski merged 4 commits intoPrestaShop:developfrom
Conversation
NeOMakinG
left a comment
NeOMakinG
left a comment
There was a problem hiding this comment.
That's cool we needed it, forking is most of the time increasing the maintenance cost more than anything
Anyway, even my comment is nitpicking so it's a 🍬 for me!
kpodemski
left a comment
kpodemski
left a comment
There was a problem hiding this comment.
It's been a while... I wanted to approve it and merge it, but there's a package-lock conflict.
Oksydan
force-pushed
the
preload-material-icons-font
branch
from
1069a49 to
7806eb8
Compare
|
@kpodemski branch rebased. |
kpodemski
left a comment
kpodemski
left a comment
There was a problem hiding this comment.
I wanted to accept it again, but you added Swiper.js. Not sure what's the reason. I don't see the usage of Swiper in Hummingbird.
|
@kpodemski fixed. |
|
@Hlavtox this has to be QA'd by a dev, do you think PS SA devs could help you with that? |
|
@ga-devfront @GytisZum guys, could you validate this PR? let me know if it looks ok for you |
ga-devfront
left a comment
ga-devfront
left a comment
There was a problem hiding this comment.
Thank's for your work, I just add one question about the configuration.
| }), | ||
| new FontPreloadPlugin({ | ||
| index: 'preload.html', | ||
| extensions: ['woff2'], |
There was a problem hiding this comment.
Why only woff2 I know eot is only for IE and we don't support it but ttf is supported by all browser.
|
thanks @Oksydan ;-) |
5 participants
webpack-font-preload-pluginplugin since it is including files query params with extension. It causing to fail at isFont condition. We can think about forking it or create our own plugin.Comparison - throttling 3G fast:
Before:
Nagranie.z.ekranu.2023-01-8.o.01.01.39.mov
After:
Nagranie.z.ekranu.2023-01-8.o.01.01.59.mov