Skip to content

Fix price slider implementation stripping parameters#452

Merged
matthieu-rolland merged 1 commit intoPrestaShop:developfrom
Hlavtox:fix-url-param
Mar 6, 2023
Merged

Fix price slider implementation stripping parameters#452
matthieu-rolland merged 1 commit intoPrestaShop:developfrom
Hlavtox:fix-url-param

Conversation

@Hlavtox
Copy link
Contributor

@Hlavtox Hlavtox commented Jan 31, 2023

Questions Answers
Description? Price slider implementation was stripping all other parameters except q. For example, this resulted in breaking filtering on a search page.
Type?
BC breaks?
Deprecations?
Fixed ticket?
Sponsor company
How to test?

@Hlavtox Hlavtox changed the title Fix price slider implementation stripping parameters and breaking filtering Fix price slider implementation stripping parameters Jan 31, 2023
@Hlavtox Hlavtox mentioned this pull request Jan 31, 2023
47 tasks
@Hlavtox
Copy link
Contributor Author

Hlavtox commented Feb 3, 2023

@NeOMakinG my dear, could you fix it for me? 😁🥰

Copy link
Contributor

@JBLach JBLach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Hlavtox
I added suggestions that should fix the problem :)

@matthieu-rolland
Copy link
Contributor

thank you @Hlavtox 👍

@matthieu-rolland matthieu-rolland merged commit 5fedf7e into PrestaShop:develop Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants