Skip to content

Url properties fix after removing product in cart#493

Merged
Hlavtox merged 2 commits intoPrestaShop:developfrom
GytisZum:url-fix-after-removing-product-in-cart
May 2, 2023
Merged

Url properties fix after removing product in cart#493
Hlavtox merged 2 commits intoPrestaShop:developfrom
GytisZum:url-fix-after-removing-product-in-cart

Conversation

@GytisZum
Copy link
Contributor

Questions Answers
Description? Previously request to delete product was in GET method. This fix making method to POST and emits prestashop updateCart method which refresh page without page load and fixes the url issue mentioned in #478 ticket.
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #487
How to test? Add products into cart and enter the cart page. After clicking remove button on product, url must stay the same.

Before product deletion:
image

After product deletion:
image

@djoelleuch djoelleuch self-assigned this May 2, 2023
Copy link

@djoelleuch djoelleuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @GytisZum ,

Tested on PS 8.0.0 .PS 8.0.3

Untitled_.May.2.2023.12_21.PM.webm

LGTM ,it's QA ✔️

Thank you 🚀 !

@Hlavtox Hlavtox merged commit b669cb7 into PrestaShop:develop May 2, 2023
@Hlavtox Hlavtox added this to the Beta milestone Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FO] CART- When you delete a product from cart, there are some extra parameters in the URL

5 participants