Skip to content

Fix : [FO] FILTERING - Resize screen to mobile#495

Merged
kpodemski merged 3 commits intoPrestaShop:developfrom
ga-devfront:ticket_483/fix_filtering
May 11, 2023
Merged

Fix : [FO] FILTERING - Resize screen to mobile#495
kpodemski merged 3 commits intoPrestaShop:developfrom
ga-devfront:ticket_483/fix_filtering

Conversation

@ga-devfront
Copy link
Contributor

@ga-devfront ga-devfront commented May 4, 2023

Questions Answers
Description? Fix the problem of front office about filtering resize screen to mobile.
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #483
Sponsor company @PrestaShopCorp.
How to test? Test with the explination inside the ticket.

@hibatallahAouadni hibatallahAouadni self-assigned this May 9, 2023
Copy link

@hibatallahAouadni hibatallahAouadni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @ga-devfront

LGTM, QA ✔️

Thanks!

@kpodemski kpodemski added this to the Beta milestone May 11, 2023
@kpodemski kpodemski merged commit 07f3b16 into PrestaShop:develop May 11, 2023
@ga-devfront ga-devfront deleted the ticket_483/fix_filtering branch May 11, 2023 07:32
import {
desktopElement, mobileElement, mobileElementId, contentValue, desktopElementId,
} from './constants/mocks/swapElements-data';
import ThemeType = Theme.ThemeType;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ga-devfront why this import? seems useless.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on my side then I test without this it fail.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this import is required elsewhere.
obraz

Is this even a valid way of importing modules?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FO] FILTERING - Resize screen to mobile

5 participants