Fix: [FO]Carrier extra content not work on deliveryFormSelector change#496
Conversation
ga-devfront
left a comment
There was a problem hiding this comment.
really good work, thank you !
hibatallahAouadni
left a comment
There was a problem hiding this comment.
Hello @GytisZum
Thanks for your PR 🙏
Unfortunately, it seems that the issue still not fixed with your PR, see the attached screen record below:
hb-pr_496.webm
Please check and feedback.
Thanks!
Hello,Thank you for response and the video you provided, however I am unable to recreate same issue on different PrestaShop versions (8.1.0 | 8.0.2).
Please check and feedback |
hibatallahAouadni
left a comment
There was a problem hiding this comment.
Hello @GytisZum
On develop branch ❌ , I still encounter the same issue as you can see the first part of the attached screen record:
- PrestaShop version:
develop - Browser: Chrome 107.0.5304.87
- Operating system: Ubuntu 22.04.1 LTS
- Module you test with:
tox_extracarrier
While with 8.1.x branch ✔️ , the issue is fixed as you can see the second part of the attached screen record:
- PrestaShop version:
8.1.x - Browser: Chrome 107.0.5304.87
- Operating system: Ubuntu 22.04.1 LTS
- Module you test with:
tox_extracarrier
pr_496.webm
Please check and feedback.
Thanks!
|
Please find attached the module I used to test this PR (developed by @Hlavtox ) |
|
Hello @hibatallahAouadni ,
|
sallemiines
left a comment
There was a problem hiding this comment.
Hello @GytisZum
Thanx for the PR !
Pr checked with develop , PS804 & PS810-rc => OK
810RC.mp4
LGTM ! QA ✔️
hibatallahAouadni
left a comment
There was a problem hiding this comment.
Hello @GytisZum
LGTM too, it seems to be a cache issue on my side 😓
pr_496.webm
As you can see it works on develop branch too.
Thanks!
|
thank you @GytisZum ! |
displayCarrierExtraContentwhich add's extra content.On page load:

Selecting method without extra content:

Selecting another method which has extra content:
