Several bug fix on cart related with products stock by GytisZum · Pull Request #501 · PrestaShop/hummingbird

GytisZum · 2023-06-06T08:57:35Z

Questions	Answers
Description?	There is several bug fixes. First of them is "Proceed to checkout" button disabling in cart page if order is not available and product has not enough quantity. Second is about the toast color which changed from yellow (warning) to red (danger). Third. The product quantity in input and in cart is set to max if customer has more then it exist in stock. This fix will not allow customer to add more products into cart if quantity is more then in stock and allow out-of-stock products is disabled is and both input and cart is falling back into previous value. As well this fix contains console error fix.
Type?	bug fix
BC breaks?	no
Deprecations?	no
Fixed ticket?	Fixes #488
Sponsor company	PrestaShop Corp.

How to test:

Button Disabled:

Steps:

Go to back office and set "Mug Today is a good day" quantity to 1 and allow out-of-stock product to order.
Go to front office and add more then 1 "Mug Today is a good day"
Go back to back office and deny out-of-stock product to order.
Go back to front office refresh the page and see the disabled button.

Toast Color:

Go to back office and set "Mug Today is a good day" quantity to 1 and deny out-of-stock product to order.
Go to front office and add more then 1 "Mug Today is a good day"
Go to cart and increase quantity of that product.
The toast color should be red.

Product quantity fix:

Go to back office and set "Mug Today is a good day" quantity to 1 and deny out-of-stock product to order.
Go to front office and add more then 1 "Mug Today is a good day"
Go to cart and increase quantity of that product.
Then amount in cart is exceeded with current stock amount you should see the toast and input value which will change back to previous.

Bonus fix:

Console error:

This error is occurred due to loading element which does not exist yet, but it's trying to initiate it on checkout pages. This error related with carrier extra content on checkout.
To test it need to check if carrier extra content works as previously.

Environment:

Hummingbird version: develop
PrestaShop version 8.1.0

M0rgan01 · 2023-06-06T12:37:16Z

src/js/components/useQuantityInput.ts

+              if (productData) {
+                if (productData.availability === 'unavailable'
+                    && productData.allow_oosp === 0
+                    && Number(productData.quantity_wanted) > Number(productData.stock_quantity)) {
+                  const diff = Number(productData.stock_quantity) - Number(productData.quantity_wanted);
+                  await sendUpdateCartRequest(productData.update_quantity_url as string, diff);
+                }
+              }


Suggested change

if (productData) {

if (productData.availability === 'unavailable'

&& productData.allow_oosp === 0

&& Number(productData.quantity_wanted) > Number(productData.stock_quantity)) {

const diff = Number(productData.stock_quantity) - Number(productData.quantity_wanted);

await sendUpdateCartRequest(productData.update_quantity_url as string, diff);

}

}

if (productData

&& productData.availability === 'unavailable'

&& productData.allow_oosp === 0

&& Number(productData.quantity_wanted) > Number(productData.stock_quantity)) {

const diff = Number(productData.stock_quantity) - Number(productData.quantity_wanted);

await sendUpdateCartRequest(productData.update_quantity_url as string, diff);

}

Thank you for the suggestion, your solution looks more readable 🔥

ga-devfront

all it's good for me, thank you for your contribution !

sallemiines

Hello @GytisZum
Thanx for this PR !

I tried to check this PR , and here is some feedback :

Proceed to checkout" button is not disable in the cart page if order is not available and product has not enough quantityif order is not available and product has not enough quantity ❌
Toast color is changed to red 🆗 but the order quantity for this product not exist ❌
You can check the attached screen recorder

Product.1789.mp4

The amount in cart is exceeded with current stock amount you should see the toast and input value which will change back to previous. ❌

You can check the attached screen recorder

Cart.mp4

Please check & feedback !
Thank y !

sallemiines

Hello @GytisZum
Thanx for this PR !

I tried to check this PR , and here is some feedback :

Proceed to checkout" button is not disable in the cart page if order is not available and product has not enough quantityif order is not available and product has not enough quantity ❌
Toast color is changed to red 🆗 but the order quantity for this product not exist ❌
You can check the attached screen recorder

Product.1789.mp4

The amount in cart is exceeded with current stock amount you should see the toast and input value which will change back to previous. ❌

You can check the attached screen recorder

Cart.mp4

Please check & feedback !
Thank y !

GytisZum · 2023-06-19T12:12:33Z

Hello,

thanks you for testing the fixes. However I see that you are using PrestaShop version 1.7.8.9.
We already know that older PrestaShop version works differently and we were informed that we need to be compatible only from PrestaShop 8.1.0

Please can you check on PrestaShop 8.1.0 ??
Thank you :)

sallemiines · 2023-06-19T15:20:57Z

Mug Today is a good day

Thnx for your feedback !

I re-test the PR on PS 810 as you mentioned before

Proceed to checkout" button is not disable in the cart page if order is not available and product has not enough quantityif order is not available and product has not enough quantity ✔️
Toast color is changed to red and the order quantity for this product ✔️ but it appears and disappear quickly in the wrong placement ❌

You can check the attached screen recorder

Mug.Today.is.a.good.day.mp4

Waiting for yr feedback !

Thank you

GytisZum · 2023-06-20T10:35:46Z

Mug Today is a good day

Thnx for your feedback !

I re-test the PR on PS 810 as you mentioned before
* **Proceed to checkout**" button is not disable in the cart page if order is not available and product has not enough quantityif order is not available and product has not enough quantity heavy_check_mark

* Toast color is changed to red and  the order quantity for this product  heavy_check_mark  but it appears and disappear quickly in the wrong placement x
You can check the attached screen recorder
Mug.Today.is.a.good.day.mp4

Waiting for yr feedback !

Thank you

Hello again,

Thank You for Your Feedback !!
I did several tests with different PrestaShop versions and I was able to recreate your issue with PrestaShop 8.1.0-beta.1

After comparison I found that real candidate version has changes in cart page which affects the behavior of the error messages.

I did some communication with the core team and got answer that tests must be done on stable version which does not exist at the moment, but closest one is PrestaShop version 8.1.0-rc.1.

Sorry I was not precise enough, but maybe you can test it on more stable version ?? :)

Waiting for the feedback
Thank you

kpodemski · 2023-06-22T17:59:24Z

@sallemiines you can use the same build that QA tests for the final 8.1 release

aniszr

Hello @GytisZum

Thanks for your PR, I tested it with 8.1.0 build 2 & Develop .

Proceed to checkout" button is not disable in the cart page if order is not available and product has not enough quantityif order is not available and product has not enough quantity ✔️
Toast color is changed to red and the order quantity for this product ✔️
Amount in cart is exceeded with current stock amount you should see the toast and input value which will change back to previous. ✔️

LGTM, QA ✔️

See attached screenshots:

Mug.Today.is.a.good.day.mp4

Thanks!

Progi1984 · 2023-06-23T18:26:39Z

Ping @Hlavtox for merge 😉

kpodemski · 2023-06-23T18:48:59Z

thanks @GytisZum

tajriba · 2023-07-05T14:57:57Z

@kpodemski hi, i want this also fixed for 8.0.X .
It works on the checkout/cart pages these changes.
But on the product page, it still add's the product to the cart. Any idea ?

GytisZum added 2 commits June 6, 2023 11:29

fix: fixed several bugs on cart related with quantity input

82d5ac7

fix: lint fix

665d439

M0rgan01 reviewed Jun 6, 2023

View reviewed changes

fix: fixed if statement into more readable

c60d11b

M0rgan01 approved these changes Jun 7, 2023

View reviewed changes

ga-devfront approved these changes Jun 12, 2023

View reviewed changes

kpodemski approved these changes Jun 16, 2023

View reviewed changes

kpodemski added the Waiting for QA label Jun 16, 2023

kpodemski added this to the Beta milestone Jun 16, 2023

hibatallahAouadni assigned hibatallahAouadni and unassigned hibatallahAouadni Jun 16, 2023

sallemiines self-assigned this Jun 19, 2023

sallemiines reviewed Jun 19, 2023

View reviewed changes

sallemiines added Waiting for Author and removed Waiting for QA labels Jun 19, 2023

sallemiines removed their assignment Jun 19, 2023

sallemiines self-assigned this Jun 19, 2023

kpodemski added Waiting for QA and removed Waiting for Author labels Jun 22, 2023

aniszr approved these changes Jun 23, 2023

View reviewed changes

sallemiines added QA ✓ and removed Waiting for QA labels Jun 23, 2023

kpodemski merged commit 1049d1e into PrestaShop:develop Jun 23, 2023

Conversation

GytisZum commented Jun 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to test:

Button Disabled:

Toast Color:

Product quantity fix:

Bonus fix:

Environment:

Uh oh!

M0rgan01 Jun 6, 2023

Choose a reason for hiding this comment

Uh oh!

GytisZum Jun 7, 2023

Choose a reason for hiding this comment

Uh oh!

ga-devfront left a comment

Choose a reason for hiding this comment

Uh oh!

sallemiines left a comment

Choose a reason for hiding this comment

Uh oh!

sallemiines left a comment

Choose a reason for hiding this comment

Uh oh!

GytisZum commented Jun 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sallemiines commented Jun 19, 2023

Uh oh!

GytisZum commented Jun 20, 2023

Uh oh!

kpodemski commented Jun 22, 2023

Uh oh!

aniszr left a comment

Choose a reason for hiding this comment

Uh oh!

Progi1984 commented Jun 23, 2023

Uh oh!

kpodemski commented Jun 23, 2023

Uh oh!

tajriba commented Jul 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

GytisZum commented Jun 6, 2023 •

edited

Loading

GytisZum commented Jun 19, 2023 •

edited

Loading

tajriba commented Jul 5, 2023 •

edited

Loading