Skip to content

Show/Hide Password: Accessibility on the button #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicosomb merged 3 commits into from
Jun 20, 2023
Merged

Show/Hide Password: Accessibility on the button #508

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8e6400e
Show/Hide Password: Accessibility on the button
yannicka Jun 13, 2023
ad95609
JS: use object destructuring
yannicka Jun 15, 2023
07c8fb9
JS: remove spaces around brackets
yannicka Jun 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/js/visible-password.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,24 @@ const initVisiblePassword = () => {
const visiblePasswordList = document.querySelectorAll(visiblePasswordMap.visiblePassword);

visiblePasswordList.forEach((input: HTMLInputElement) => {
const button = input?.nextElementSibling;
const button = input?.nextElementSibling as HTMLElement;

button?.addEventListener('click', () => {
const newType = input.getAttribute('type') === 'text' ? 'password' : 'text';
input.setAttribute('type', newType);
button.setAttribute('aria-expanded', newType === 'text' ? 'true' : 'false');

const icon = button.firstElementChild;

if (icon) {
icon.innerHTML = newType === 'text' ? 'visibility_off' : 'visibility';

const textShow = button.dataset.textShow;
const textHide = button.dataset.textHide;
Copy link
Contributor

@kpodemski kpodemski Jun 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const textHide = button.dataset.textHide;
const { textHide, textShow } = button.dataset;

that should do it with eslint errors

Copy link
Contributor Author

@yannicka yannicka Jun 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, updated!


if (textShow && textHide) {
button.setAttribute('aria-label', newType === 'text' ? textHide : textShow);
}
}
});
});
Expand Down
6 changes: 4 additions & 2 deletions templates/_partials/form-fields.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,8 +145,10 @@
class="btn btn-primary"
type="button"
data-action="show-password"
data-text-show="{l s='Show' d='Shop.Theme.Actions'}"
data-text-hide="{l s='Hide' d='Shop.Theme.Actions'}"
data-text-show="{l s='Show Password' d='Shop.Theme.Actions'}"
data-text-hide="{l s='Hide Password' d='Shop.Theme.Actions'}"
aria-label="{l s='Show Password' d='Shop.Theme.Actions'}"
aria-expanded="false"
>
<i class="material-icons">visibility</i>
</button>
Expand Down
12 changes: 8 additions & 4 deletions templates/customer/password-new.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,10 @@
class="btn btn-primary"
type="button"
data-action="show-password"
data-text-show="{l s='Show' d='Shop.Theme.Actions'}"
data-text-hide="{l s='Hide' d='Shop.Theme.Actions'}"
data-text-show="{l s='Show Password' d='Shop.Theme.Actions'}"
data-text-hide="{l s='Hide Password' d='Shop.Theme.Actions'}"
aria-label="{l s='Show Password' d='Shop.Theme.Actions'}"
aria-expanded="false"
>
<i class="material-icons">visibility</i>
</button>
Expand All @@ -52,8 +54,10 @@
class="btn btn-primary"
type="button"
data-action="show-password"
data-text-show="{l s='Show' d='Shop.Theme.Actions'}"
data-text-hide="{l s='Hide' d='Shop.Theme.Actions'}"
data-text-show="{l s='Show Password' d='Shop.Theme.Actions'}"
data-text-hide="{l s='Hide Password' d='Shop.Theme.Actions'}"
aria-label="{l s='Show Password' d='Shop.Theme.Actions'}"
aria-expanded="false"
>
<i class="material-icons">visibility</i>
</button>
Expand Down