Skip to content

Fix: product listing responsive #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicosomb merged 3 commits into from
Jun 26, 2023
Merged

Fix: product listing responsive #515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1905b7c
fix: product miniatures infos alignment
ga-devfront Jun 22, 2023
c5cf608
fix: product miniatures responsive
ga-devfront Jun 23, 2023
2f93c7f
fix: scss lint
ga-devfront Jun 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/scss/core/components/product/_product-miniature.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ $component-name: product-miniature;
& &__infos {
position: relative;
z-index: 90;
display: flex;
flex-direction: column;
flex-grow: 1;
padding: 0;

&__top,
Expand All @@ -17,11 +20,18 @@ $component-name: product-miniature;
}

&__top {
height: 100%;
padding-top: 0.5rem;
}

&__bottom {
margin-top: auto;
margin-bottom: 1rem;
@media (max-width: 767px) {
.quantity-button input {
max-width: unset;
}
}
}
}

Expand Down
30 changes: 15 additions & 15 deletions templates/catalog/_partials/miniatures/product.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,25 +15,25 @@
{if $product.cover}
<picture>
{if isset($product.cover.bySize.default_md.sources.avif)}
<source
<source
srcset="
{$product.cover.bySize.default_xs.sources.avif} 120w,
{$product.cover.bySize.default_m.sources.avif} 200w,
{$product.cover.bySize.default_md.sources.avif} 320w,
{$product.cover.bySize.product_main.sources.avif} 720w"
sizes="(min-width: 1300px) 720px, (min-width: 768px) 50vw, 50vw"
sizes="(min-width: 1300px) 720px, (min-width: 768px) 50vw, 50vw"
type="image/avif"
>
{/if}

{if isset($product.cover.bySize.default_md.sources.webp)}
<source
<source
srcset="
{$product.cover.bySize.default_xs.sources.webp} 120w,
{$product.cover.bySize.default_m.sources.webp} 200w,
{$product.cover.bySize.default_md.sources.webp} 320w,
{$product.cover.bySize.product_main.sources.webp} 720w"
sizes="(min-width: 1300px) 320px, (min-width: 768px) 120px, 50vw"
sizes="(min-width: 1300px) 320px, (min-width: 768px) 120px, 50vw"
type="image/webp"
>
{/if}
Expand All @@ -45,8 +45,8 @@
{$product.cover.bySize.default_m.url} 200w,
{$product.cover.bySize.default_md.url} 320w,
{$product.cover.bySize.product_main.url} 720w"
sizes="(min-width: 1300px) 320px, (min-width: 768px) 120px, 50vw"
src="{$product.cover.bySize.default_md.url}"
sizes="(min-width: 1300px) 320px, (min-width: 768px) 120px, 50vw"
src="{$product.cover.bySize.default_md.url}"
width="{$product.cover.bySize.default_md.width}"
height="{$product.cover.bySize.default_md.height}"
loading="lazy"
Expand All @@ -58,25 +58,25 @@
{else}
<picture>
{if isset($urls.no_picture_image.bySize.default_md.sources.avif)}
<source
<source
srcset="
{$urls.no_picture_image.bySize.default_xs.sources.avif} 120w,
{$urls.no_picture_image.bySize.default_m.sources.avif} 200w,
{$urls.no_picture_image.bySize.default_md.sources.avif} 320w,
{$urls.no_picture_image.bySize.product_main.sources.avif} 720w"
sizes="(min-width: 1300px) 720px, (min-width: 768px) 50vw, 50vw"
sizes="(min-width: 1300px) 720px, (min-width: 768px) 50vw, 50vw"
type="image/avif"
>
{/if}

{if isset($urls.no_picture_image.bySize.default_md.sources.webp)}
<source
<source
srcset="
{$urls.no_picture_image.bySize.default_xs.sources.webp} 120w,
{$urls.no_picture_image.bySize.default_m.sources.webp} 200w,
{$urls.no_picture_image.bySize.default_md.sources.webp} 320w,
{$urls.no_picture_image.bySize.product_main.sources.webp} 720w"
sizes="(min-width: 1300px) 320px, (min-width: 768px) 120px, 50vw"
sizes="(min-width: 1300px) 320px, (min-width: 768px) 120px, 50vw"
type="image/webp"
>
{/if}
Expand All @@ -88,10 +88,10 @@
{$urls.no_picture_image.bySize.default_m.url} 200w,
{$urls.no_picture_image.bySize.default_md.url} 320w,
{$urls.no_picture_image.bySize.product_main.url} 720w"
sizes="(min-width: 1300px) 320px, (min-width: 768px) 120px, 50vw"
sizes="(min-width: 1300px) 320px, (min-width: 768px) 120px, 50vw"
width="{$urls.no_picture_image.bySize.default_md.width}"
height="{$urls.no_picture_image.bySize.default_md.height}"
src="{$urls.no_picture_image.bySize.default_md.url}"
src="{$urls.no_picture_image.bySize.default_md.url}"
loading="lazy"
alt="{l s='No image available' d='Shop.Theme.Catalog'}"
title="{l s='No image available' d='Shop.Theme.Catalog'}"
Expand Down Expand Up @@ -169,10 +169,10 @@
</div>

{if $product.add_to_cart_url}
<form action="{$urls.pages.cart}" method="post" class="d-flex align-items-center mt-3">
<form action="{$urls.pages.cart}" method="post" class="d-flex flex-wrap flex-md-nowrap gap-3 align-items-center mt-3">
<input type="hidden" value="{$product.id_product}" name="id_product">
<input type="hidden" name="token" value="{$static_token}" />
<div class="quantity-button js-quantity-button">
<div class="quantity-button js-quantity-button w-100 w-sm-auto">
{include file='components/qty-input.tpl'
attributes=[
"id"=>"quantity_wanted_{$product.id_product}",
Expand All @@ -182,7 +182,7 @@
marginHelper="mb-0"
}
</div>
<button data-button-action="add-to-cart" class="btn btn-primary ms-3">
<button data-button-action="add-to-cart" class="btn btn-primary flex-grow-1 flex-md-grow-0">
<i class="material-icons" aria-hidden="true">&#xe854;</i>
<span class="visually-hidden">{l s='Add to cart' d='Shop.Theme.Actions'}</span>
</button>
Expand Down