fix: quantity input of additional products have an issue after changing quantity of a product in the cart#541
Merged
ga-devfront merged 3 commits intoPrestaShop:developfrom Sep 7, 2023
Conversation
Contributor
tblivet
commented
Aug 10, 2023
tblivet
commented
| Questions | Answers |
|---|---|
| Description? | Correct the issue 540 |
| Type? | bug fix |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | Fixes #540 |
| Sponsor company | @PrestaShopCorp |
| How to test? | You can refer to the issue |
Contributor
|
Seems that built assets got into the PR |
kpodemski
previously requested changes
Aug 22, 2023
Contributor
kpodemski
left a comment
kpodemski
left a comment
There was a problem hiding this comment.
Compiled assets shouldn't be versioned.
Contributor
Author
|
The compiled files are removed ! |
ancardinale
approved these changes
Aug 31, 2023
Contributor
|
No response from the people who blocked the PR and the changes are be done. |
ga-devfront
previously approved these changes
Sep 5, 2023
ancardinale
approved these changes
Sep 5, 2023
davidglezz
reviewed
Sep 6, 2023
djoelleuch
previously approved these changes
Sep 6, 2023
ga-devfront
dismissed stale reviews from djoelleuch and themself
via
8fbbb22
ga-devfront
approved these changes
Sep 7, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.