Add classes to make menu elements tall as parent#547
Merged
nicosomb merged 2 commits intoPrestaShop:developfrom Sep 12, 2023
Merged
Add classes to make menu elements tall as parent#547nicosomb merged 2 commits intoPrestaShop:developfrom
nicosomb merged 2 commits intoPrestaShop:developfrom
Conversation
tblivet
requested changes
Sep 6, 2023
Contributor
tblivet
left a comment
tblivet
left a comment
There was a problem hiding this comment.
Hello 👋
I think you want to do this modification, because if the logo is higher than the menu, we cannot access the submenu ? Is it right ?
Your modification looks good, but with those, the logo is no longer vertically centered.
So I suggest adding some classes to fix it.
tblivet
requested changes
Sep 6, 2023
Co-authored-by: Blivet Thibault <110676325+tblivet@users.noreply.github.com>
Contributor
Author
|
Thanks tblivet. You were right in your suggestions. Align-items-stretch it's not necessary, because in flex normal it's the same as stretch, but it doesn't matter. |
tblivet
approved these changes
Sep 7, 2023
matks
approved these changes
Sep 7, 2023
|
Hello @rodriciru, I tested your PR and it's good for me! 🎉 Thanks! |
paulnoelcholot
approved these changes
Sep 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #546
I made the changes using bootstrap classes.
I don't find any drawbacks. If anyone find something wrong, tell me