Skip to content

Improvement: buttons, accessibilites #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthieu-rolland merged 1 commit into from
Oct 4, 2023
Merged

Improvement: buttons, accessibilites #552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions modules/blockwishlist/views/templates/components/modals/add-to-wishlist.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,9 @@
</div>

<div class="modal-footer">
<a @click="openNewWishlistModal" class="wishlist-add-to-new text-primary">
<div role="button" @click="openNewWishlistModal" class="wishlist-add-to-new text-primary">
<i class="material-icons text-primary" aria-hidden="true">add_circle_outline</i> {$newWishlistCTA}
</a>
</div>
</div>
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion modules/ps_contactinfo/ps_contactinfo.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

<p class="footer__block__title d-none d-md-flex">{l s='Store information' d='Shop.Theme.Global'}</p>

<div class="footer__block__toggle d-md-none collapsed" data-bs-target="#contact-infos" data-bs-toggle="collapse" aria-expanded="false">
<div role="button" class="footer__block__toggle d-md-none collapsed" data-bs-target="#contact-infos" data-bs-toggle="collapse" aria-expanded="false">
<span class="footer__block__title">{l s='Store information' d='Shop.Theme.Global'}</span>
<i class="material-icons" aria-hidden="true">arrow_drop_down</i>
</div>
Expand Down
2 changes: 1 addition & 1 deletion modules/ps_customeraccountlinks/ps_customeraccountlinks.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
</a>
</p>

<div class="footer__block__toggle d-md-none collapsed" data-bs-target="#footer_account_list" data-bs-toggle="collapse" aria-expanded="false">
<div role="button" class="footer__block__toggle d-md-none collapsed" data-bs-target="#footer_account_list" data-bs-toggle="collapse" aria-expanded="false">
<span class="footer__block__title">{l s='Your account' d='Shop.Theme.Customeraccount'}</span>
<i class="material-icons" aria-hidden="true">arrow_drop_down</i>
</div>
Expand Down
2 changes: 1 addition & 1 deletion modules/ps_legalcompliance/views/templates/hook/hookDisplayFooter.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

<p class="footer__block__title d-none d-md-flex">{l s='Information' d='Modules.Legalcompliance.Shop'}</p>

<div class="footer__block__toggle d-md-none collapsed" data-target="#footer_eu_about_us_list" data-bs-toggle="collapse">
<div role="button" class="footer__block__toggle d-md-none collapsed" data-target="#footer_eu_about_us_list" data-bs-toggle="collapse">
<span class="footer__block__title">{l s='Information' d='Modules.Legalcompliance.Shop'}</span>
<i class="material-icons" aria-hidden="true">arrow_drop_down</i>
</div>
Expand Down
2 changes: 1 addition & 1 deletion modules/ps_linklist/views/templates/hook/linkblock.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

<p class="footer__block__title d-none d-md-flex">{$linkBlock.title}</p>

<div class="footer__block__toggle d-md-none collapsed" aria-expanded="false" data-bs-target="#footer_sub_menu_{$linkBlock.id}" data-bs-toggle="collapse">
<div role="button" class="footer__block__toggle d-md-none collapsed" aria-expanded="false" data-bs-target="#footer_sub_menu_{$linkBlock.id}" data-bs-toggle="collapse">
<span class="footer__block__title">{$linkBlock.title}</span>
<i class="material-icons" aria-hidden="true">arrow_drop_down</i>
</div>
Expand Down
4 changes: 2 additions & 2 deletions templates/components/qty-input.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
{/if}

<div class="input-group flex-nowrap{if isset($marginHelper)} {$marginHelper}{else} mb-3{/if}">
<button class="btn {$prepend.button} js-{$prepend.button}-button" type="button">
<button role="button" aria-label="{$prepend.button}" class="btn {$prepend.button} js-{$prepend.button}-button" type="button">
<i class="material-icons" aria-hidden="true">&#x{$prepend.icon};</i>
<i class="material-icons confirmation d-none">&#x{$prepend.confirm_icon};</i>
<div class="spinner-border spinner-border-sm align-middle d-none" role="status"></div>
Expand All @@ -39,7 +39,7 @@
min="1"
{* End of default attributes *}
/>
<button class="btn {$append.button} js-{$append.button}-button" type="button">
<button role="button" aria-label="{$append.button}" class="btn {$append.button} js-{$append.button}-button" type="button">
<i class="material-icons" aria-hidden="true">&#x{$append.icon};</i>
<i class="material-icons confirmation d-none">&#x{$append.confirm_icon};</i>
<div class="spinner-border spinner-border-sm align-middle d-none" role="status"></div>
Expand Down