[ISSUE-555] Add old hooks from classic theme#556
Merged
ga-devfront merged 1 commit intoPrestaShop:developfrom Oct 18, 2023
Merged
[ISSUE-555] Add old hooks from classic theme#556ga-devfront merged 1 commit intoPrestaShop:developfrom
ga-devfront merged 1 commit intoPrestaShop:developfrom
Conversation
Contributor
tblivet
commented
Oct 17, 2023
tblivet
commented
| Questions | Answers |
|---|---|
| Description? | Add old classic theme hooks. The displaySearch hook has not been added because in classic theme he was only used on 404 error page and if we add it on this page this will generate duplicate ID on the page. #555 |
| Type? | improvement |
| BC breaks? | no |
| Deprecations? | |
| Fixed ticket? | Fixes #555 |
| Sponsor company | @PrestaShopCorp |
| How to test? | These hooks are just called in the code |
matthieu-rolland
approved these changes
Oct 17, 2023
boherm
approved these changes
Oct 17, 2023
ga-devfront
approved these changes
Oct 18, 2023
|
It can/should be tested by a dev :) |
Hlavtox
approved these changes
Oct 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.