Usability improvements for search widget#572
Merged
boherm merged 2 commits intoPrestaShop:developfrom Jan 4, 2024
Merged
Conversation
Contributor
tswfi
commented
Dec 20, 2023
tswfi
commented
| Questions | Answers |
|---|---|
| Description? | Usability improvements for search widget. Focus on the input from larger area, Search by clicking on the icon (for people without enter key), use type=search to get "clear" x in the field automagically |
| Type? | improvement |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | Fixes #543 (well at least touches on the subject ;) |
| Sponsor company | |
| How to test? | Click on the search widget area (but not on the input for example the search icon), focus goes to the input field (better for touch devices to have larger click area). Write something in the field, see the "x" button your browser adds by default (https://caniuse.com/input-search). Click on the icon when there is text in the field, the form is submitted and the search happens. |
mflasquin
approved these changes
Dec 29, 2023
florine2623
approved these changes
Jan 4, 2024
florine2623
left a comment
florine2623
left a comment
There was a problem hiding this comment.
Hello @tswfi ,
Works as explained in the How to test :
Screen.Recording.2024-01-04.at.11.08.24.mov
Although I think the UX could be improved in another PR ^^
It is QA ✅
boherm
approved these changes
Jan 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.