productcomments - Make rating mandatory#577
Merged
nicosomb merged 1 commit intoPrestaShop:developfrom Mar 18, 2024
Merged
Conversation
mflasquin
approved these changes
Jan 24, 2024
kpodemski
previously requested changes
Jan 25, 2024
Contributor
kpodemski
left a comment
There was a problem hiding this comment.
Blocking not to merge before productcomments PR.
Contributor
Author
|
@paulnoelcholot Please recheck PrestaShop/productcomments#197 |
|
Hi @kpodemski, The PR is now merged, @leemyongpakvn can you apply your last changes on this PR ? Thank you |
Contributor
|
@AureRita The last commit in PrestaShop/productcomments#197 stays in module's JS. There is no change needed for theme. |
SharakPL
approved these changes
Feb 12, 2024
boherm
approved these changes
Feb 14, 2024
Contributor
|
@kpodemski The productcomments PR is now merged. |
Contributor
|
@AureRita We are in need or re-QA |
|
Thank you for your PR, I tested it and it seems to works as you can see : recording.141.webmTested on develop and 8.1.x Because the PR seems to works as expected, It's QA ✔️ Thank you |
AureRita
approved these changes
Mar 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Don't forget to clone a clean develop branch of hummingbird, as well as clear browser cache, PS cache before testing ;)