Fix missing add to wishlist button and modals backdrop#584
Merged
SharakPL merged 3 commits intoPrestaShop:developfrom Feb 6, 2024
Merged
Fix missing add to wishlist button and modals backdrop#584SharakPL merged 3 commits intoPrestaShop:developfrom
SharakPL merged 3 commits intoPrestaShop:developfrom
Conversation
Hlavtox
previously approved these changes
Jan 31, 2024
Contributor
Author
|
Further changes will be needed inside the productcomments module to avoid this empty space when no rating is available. It's meant for absolutely positioned Classic verstion and it only changes IMO it's not the best place for it in Hummingbird. Products without rating will have either big empty space or different position of price, quantity and button and there will be layout shifts all over the page. Maybe we should keep it on the product cover like in Classic, but rather as a single star with score in it eg. 4.5/5, instead of 5 stars. |
boherm
previously approved these changes
Feb 1, 2024
Contributor
Author
Hlavtox
approved these changes
Feb 2, 2024
Contributor
Author
|
Thanks @AureRita |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


thumbnail-containerneeds to be back in its original place.It temporary breaks the product rating, but this needs to be fixed in the productcomments module, where wrong selector is being used in js (fix: PrestaShop/productcomments#198)
Before
After