Templates: double quotes => single quote (for Smarty strings)#601
Templates: double quotes => single quote (for Smarty strings)#601Hlavtox merged 2 commits intoPrestaShop:developfrom
Conversation
yannicka
commented
Feb 23, 2024
| Questions | Answers |
|---|---|
| Description? | Chunk of #593. Strings in Smarty templates all (or almost all) use single quotes instead of double quotes. |
| Type? | refactor |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | N/A |
| Sponsor company | N/A |
| How to test? | Install the theme and browse the website. |
|
@yannicka after the merge of one of your PRs there are some conflicts there :( probably it will be a bit of a pain since your previous PR changed spaces 😓 |
|
Should be good ;) |
florine2623
left a comment
There was a problem hiding this comment.
Hello @yannicka ,
I tested with develop branch of PS and PHP 8.1.
I have an internal server error when installing the hummingbird theme PR.
With classic theme, it works as expected.
Could you check ? :)
Thanks!
|
@florine2623, could you check what the logs say? because this is just a generic error message |
|
For my part, I can install the theme with this modification, and the theme works. If you activate debug mode, it will display more information. |
florine2623
left a comment
There was a problem hiding this comment.
Hello @yannicka ,
Retested the theme on develop. I do not have any errors. Probably a problem with my server 😅
Tested :
- creation of a product in BO and checked product page in FO
- checked categories page
- log into customer page
- checked customer account pages
- processed to checkout
- checked content pages
LGTM ✅