Conversation
Enhance product list display for various layouts and introduce breakpoints for improved mobile display.
Enhanced pagination and added mobile optimizations.
Hlavtox
left a comment
There was a problem hiding this comment.
Please keep one column for mobile. In the issue, it was just a suggestion from the author.
Hi @Hlavtox, I don't really understand, you want me to remove one column for mobile? |
|
@tblivet Ah sorry, too early in the morning. :-) I meant to keep two columns on mobiles, unless on VERY small screen sizes. We can fit more data without as much scrolling. |
|
@Hlavtox, I think removing it is not a good idea because with 2 products per line on very small devices, we really lose in terms of visibility. As you say, we can fit more data, but we display more data in a bad way. I think it's a good compromise. What do you think? |
|
@tblivet Yeah! Good solution. :-) Do you want to move the breakpoint or add another one? |
|
@Hlavtox, Perfect 👍 No, just move it because it's already a new breakpoint! |
florine2623
left a comment
There was a problem hiding this comment.
Hello @tblivet ,
Thanks for the PR.
When I try on desktop screen, the 3 dots button doesn't work :
Screen.Recording.2024-06-06.at.11.46.12.mov
On mobile 320px size, the pagination design is as expected.
But it doesn't work so well. The 3-dots button doesn't always work.
Screen.Recording.2024-06-06.at.11.47.44.mov
Although this is not blocking, before this PR, it was already like this. It can be fixed later.
The products are well displayed on mobile size.
It is QA ✅
|
Thank you, @florine2623 🙏 |
Most of the points described in the issue have already been addressed. The remaining ones have been tackled as follows: