Removed .env configuration

[nicosomb]

Questions	Answers
Description?	Removed .env configuration
Type?	improvement
BC breaks?	no
Deprecations?	no
Sponsor company	PrestaShop SA

This PR allows to fix the issue I have here PrestaShop/PrestaShop#36198 (comment) to embed HB in PrestaShop core.

[nicosomb]

I know that some variables will remain empty, but the build seems ok like this.

Removing .env dependency will help us to ship hummingbird in prestashop core.

[Hlavtox]

The env configuration was added for a reason. 🤔 Ping @Oksydan @NeOMakinG

[nicosomb]

I know that there were some reasons ... but we can't find them.

[Hlavtox]

PR that introduced this, with discussion - #67

[nicosomb]

OK so it seems that you warned about this issue...

[Oksydan]

@nicosomb .env file is being used by webpack-dev-server mostly to improve DX. Why would you like to get ride of this like this 🤔.

[nicosomb]

@Oksydan I understand, but can you tell us how can we ship it in PrestaShop core please ?

We want to add Hummingbird as a dependency in composer.json (see my PR here PrestaShop/PrestaShop#36198). So we have to know how to fill the .env file during the assets build process.

[Oksydan]

Hmmmmm we could pass arguments in the compilation process. If the process is building a theme, we could simply not check if the .env file exists, otherwise check for its existence and terminate the process. For missing values from env, we could set default values:

const {
  PORT: port = null,
  PUBLIC_PATH: publicPath = null,
  SERVER_ADDRESS: serverAddress = null,
  SITE_URL: siteURL = null,
} = process.env;

THB we do not need these values in the compilation process. It is only required for the development process.

[nicosomb]

@Oksydan thank you for the details. I will improve my PR.

[boherm]

Why this diff? 🤔

[boherm]

This is related to this PR: #609

[nicosomb]

I know that. But it seems that it breaks UI tests.

[boherm]

I think that's an issue about UI tests then.
If we merge your diff, we reintroduce the "Add to cart" button for combinations products, and his buggy behaviour in that particular case 🤔

But anyway, I don't block your PR, just I prefer to warn you about this! 😉

[Hlavtox]

I think the change is legit, add to cart url should be handled on product lazy array settings. For combination, it's availability depends on prestashop settings (enable add to cart button in listings when product has combinations on/off).

[nicosomb]

@Hlavtox we have to go forward, could you please remove your request approval?
if necessary, we can still open a new PR later.

[florine2623]

Hello @nicosomb ,

What are the steps to reproduce ?
Do we just need to make sure the theme is well installed ?

[florine2623]

Hello @nicosomb ,

Hummingbird is well installed.
Made an order with all types of products, order process is working as expected.

LGTM ✅
Thanks!