Merged
Conversation
ga-devfront
previously approved these changes
Jun 11, 2024
boherm
previously approved these changes
Jun 11, 2024
|
This pull request seems to contain new translation strings. I have summarized them below to ease up review:
(Note: this is an automated message, but answering it will reach a real human) |
boherm
approved these changes
Jun 12, 2024
florine2623
approved these changes
Jun 12, 2024
florine2623
left a comment
florine2623
left a comment
There was a problem hiding this comment.
Hello @tblivet ,
Works as expected.
Tested deleting the product from Remove button and from Quantity button. The alert is displayed as it should. After Refreshing the page, the alert is removed. The link to product is correct. Tested re-adding the product after deleting it. All is good.
It is QA ✅
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new feature where a closable alert appears when a product is removed from the cart. This alert contains a link to the deleted product, allowing users to navigate back to the product page in case the deletion was unintended.
Steps to Reproduce
Video:
cart_remove_alert.mov