Conversation
florine2623
left a comment
There was a problem hiding this comment.
Hello @tblivet ,
Thanks for the PR ! 🎉
Tested all elements in Configuration block.
Tested Reporting reviews
CRUD Review criterias
Pagination looks good
Rating star color is correct
BUG 1
The button Read user reviews has an anchor a little to low. I can't see the name of the user who posted a comment.
Screen.Recording.2024-06-14.at.16.18.51.mov
BUG 2
Same issue with write your review button. It scrolls down but I don't see the button to write my review.
I actually expect it to open the modal so I can Write my review directly. What do you think ? I couldn't find any info on the issue regarding that topic.
Screen.Recording.2024-06-14.at.16.20.15.mov
Thanks!
|
Hi @florine2623, Thank you for the QA ! Bug 1: I have noticed the bug you reported. However, I think this can be fixed outside this PR to address the problem globally if other links in the theme use scroll anchors. Bug 2: You're right 👍 the "Write your review" button should open the modal directly, so I have made a new commit to correct it. |
|
This pull request seems to contain new translation strings. I have summarized them below to ease up review:
(Note: this is an automated message, but answering it will reach a real human) |
florine2623
left a comment
There was a problem hiding this comment.
Hello @tblivet ,
BUG 2 is fixed ^^ ✅
Thanks!
productcomments.productcommentsmodule needs to be tested.Before:

After:
