Conversation
tblivet
commented
Jul 16, 2024
tblivet
commented
| Questions | Answers |
|---|---|
| Description? | Allow the main menu to display on multiple rows instead of using the full row width when containing many items. Also, change the submenu top position to handle the case when multiple rows contain submenus. |
| Type? | improvement |
| BC breaks? | no |
| Deprecations? | |
| Fixed ticket? | Fix #637 |
| Sponsor company | @PrestaShopCorp |
| How to test? | You can refer to the issue #637 |
nicosomb
left a comment
nicosomb
left a comment
There was a problem hiding this comment.
OK for the css / tpl part.
florine2623
left a comment
florine2623
left a comment
There was a problem hiding this comment.
Hello @tblivet ,
Thanks for the PR !
Not all elements are displayed, but I guess that i'ts the wanted behavior, as 50 elements can't be displayed all in one line. ✅
I can't click on any submenu. ❌
Screen.Recording.2024-07-17.at.11.08.40.mov
Could you check ?
Thanks!
|
Hello @florine2623, I think you have the old version. Maybe the assets have not been recompiled because the menu should not be displayed in full row, it should fit between the logo and the search bar 🤔 |
florine2623
left a comment
florine2623
left a comment
There was a problem hiding this comment.
Hello @tblivet ,
LGTM on the shape of the menu ✅
Screen.Recording.2024-07-19.at.09.37.14.mov
When there are more than 3 sub-categories, the last one is not well displayed. But that's an issue for another PR :)
It is QA ✅
|
PR merged, well done! Message to @PrestaShop/committers: do not forget to milestone it before the merge. |
5 participants
