Put back double quotes to fix inclusion error#652
Merged
kpodemski merged 2 commits intoPrestaShop:developfrom Nov 17, 2024
Merged
Put back double quotes to fix inclusion error#652kpodemski merged 2 commits intoPrestaShop:developfrom
kpodemski merged 2 commits intoPrestaShop:developfrom
Conversation
Contributor
maxime-aknin
commented
Sep 6, 2024
maxime-aknin
commented
| Questions | Answers |
|---|---|
| Description? | Fix Bug in smarty template inclusion |
| Type? | bug fix |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | Fixes this ticket |
| Sponsor company | |
| How to test? | Go visit a category page in dev mode |
|
Hello @maxime-aknin! This is your first pull request on hummingbird repository of the PrestaShop project. Thank you, and welcome to this Open Source community! |
nicosomb
approved these changes
Sep 6, 2024
boherm
approved these changes
Sep 6, 2024
|
Waiting for the author's feedback on the related issue |
Contributor
|
@florine2623 Can we merge this? |
|
PR merged, well done! Message to @PrestaShop/committers: do not forget to milestone it before the merge. |
Contributor
|
I tested it on my local installation, where I encountered this error. It works as expected. Thank you @maxime-aknin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.