Skip to content

Fix issue #664#665

Merged
Hlavtox merged 1 commit intoPrestaShop:developfrom
marsaldev:develop
Dec 4, 2024
Merged

Fix issue #664#665
Hlavtox merged 1 commit intoPrestaShop:developfrom
marsaldev:develop

Conversation

@marsaldev
Copy link
Contributor

@marsaldev marsaldev commented Dec 2, 2024

Questions Answers
Description? Center horizontally header icons on mobile view
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? Fixes 664
Sponsor company Myself
How to test? Upload a logo with an height greater than the default one, even a square logo could be fine, navigate with mobile view in the browser

@florine2623 florine2623 self-assigned this Dec 4, 2024
Copy link

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @marsaldev ,

Tested with mobile / desktop view.

Before :
Screenshot 2024-12-04 at 16 29 13

After :
Screenshot 2024-12-04 at 16 35 01

Thanks !
It is Qa ✅

@Hlavtox Hlavtox merged commit a30420a into PrestaShop:develop Dec 4, 2024
@ps-jarvis
Copy link

PR merged, well done!

Message to @PrestaShop/committers: do not forget to milestone it before the merge.

@Hlavtox
Copy link
Contributor

Hlavtox commented Dec 4, 2024

Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Center the icons in the header

5 participants