Skip to content

[Idea] Add the <textarea> element among the available types for the FromField class#698

Merged
nicosomb merged 2 commits intoPrestaShop:developfrom
Codencode:idea-38591-Add-the-textarea-element-among-the-available-types-for-the-FromField-class
Jun 2, 2025
Merged

[Idea] Add the <textarea> element among the available types for the FromField class#698
nicosomb merged 2 commits intoPrestaShop:developfrom
Codencode:idea-38591-Add-the-textarea-element-among-the-available-types-for-the-FromField-class

Conversation

@Codencode
Copy link
Contributor

@Codencode Codencode commented May 5, 2025

Questions Answers
Description? Added the textarea type
Type? new feature
BC breaks? no
Deprecations? no
Fixed ticket? Fixes PrestaShop/PrestaShop#38591
Sponsor company @Codencode
How to test? Attached test module that adds the new field to the account creation form.

@Codencode
Copy link
Contributor Author

Installing the test module adds the new field to the account registration form, as shown in the attached screenshot.
Screenshot 2025-05-05 at 09-27-26 Registration

Test module: idea_38591.zip

kpodemski
kpodemski previously approved these changes May 13, 2025
@github-project-automation github-project-automation bot moved this to Ready for review in PR Dashboard May 13, 2025
@ps-jarvis ps-jarvis moved this from Ready for review to To be tested in PR Dashboard May 13, 2025
@kpodemski
Copy link
Contributor

cc @tblivet

Co-authored-by: Blivet Thibault <110676325+tblivet@users.noreply.github.com>
Copy link
Contributor

@tblivet tblivet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you 👍

@SiraDIOP SiraDIOP self-assigned this May 19, 2025
Copy link

@SiraDIOP SiraDIOP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Codencode ,

Thank you for your PR, ^^
I tested the pr but the field I have is not the same as the one on the photo. Is this normal?
Capture d’écran 2025-05-20 à 16 30 55

Thank you ^^

@Codencode
Copy link
Contributor Author

Hello @SiraDIOP,

No, it’s not normal. There could be 2 issues:

  1. You didn’t apply the PR correctly.
  2. You didn’t recompile the templates.

Case 1

Check that the new instructions found here are present in the file themes/hummingbird/templates/_partials/form-fields.tpl:
https://github.com/PrestaShop/hummingbird/pull/698/files

Case 2
In Admin > Advanced Parameters > Performance, make sure that Template compilation is not set to Never recompile template files. If it is, you need to clear the cache (use the Clear cache button on the same page).

Copy link

@SiraDIOP SiraDIOP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Codencode,

So I'll explain how I did it and you can tell me if I missed anything ^^

First, I put this command line in my terminal

nvm use 20
cd themes
git clone https://github.com/PrestaShop/hummingbird.git
cd hummingbird
git prc origin 698 dev
npm ci
cd webpack
nano .env-example

Then I put this

npm run build
install hummingbird in BO

Then I reinstalled my shop and went to module and installed the zip idea_38591.zip

Did i miss anything?

Thanks in advance ^^

@Codencode
Copy link
Contributor Author

Hello @SiraDIOP,
I'm not very experienced with Linux shell, but I believe there might be an issue with this line:

git prc origin 698 dev

However, to make sure the PR was properly imported, you just need to verify that in the file themes/hummingbird/templates/_partials/form-fields.tpl
you can find the instruction:

{elseif $field.type === 'textarea'}

at line 158.

@SiraDIOP
Copy link

SiraDIOP commented Jun 2, 2025

Hello @Codencode,

Thanks for the PR,
I hadn't installed the PR correctly, but it's fine now.

Everything is ok for me :)
Capture d’écran 2025-06-01 à 00 14 20

Thanks

@nicosomb nicosomb added this to the v0.2.1 milestone Jun 2, 2025
@nicosomb nicosomb merged commit 77437c3 into PrestaShop:develop Jun 2, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from To be tested to Merged in PR Dashboard Jun 2, 2025
@ps-jarvis ps-jarvis moved this from Merged to To be tested in PR Dashboard Jun 2, 2025
@Codencode Codencode deleted the idea-38591-Add-the-textarea-element-among-the-available-types-for-the-FromField-class branch June 3, 2025 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants