refactor: remove <style> section and use bootstrap class instead

[bibips]

Questions	Answers
Description?	Remove <style> section and use bootstrap class instead (in compliance with the BEM convention)
Type?	refactor
BC breaks?	no
Deprecations?	no
Fixed ticket?	Fixes #721
Sponsor company
How to test?	Go to Contact page and check whether the URL input field is still hidden.

[ps-jarvis]

Hello @bibips!

This is your first pull request on hummingbird repository of the PrestaShop project.

Thank you, and welcome to this Open Source community!

[aomaxime]

Ok for me

[Hlavtox]

Just to check - Why is the form input hidden? Is it always?

If not, are we sure the related js triggers class or style?
If yes, wouldn't an input type=hidden be better?

[bibips]

Just to check - Why is the form input hidden? Is it always?

If not, are we sure the related js triggers class or style? If yes, wouldn't an input type=hidden be better?

If I'm not wrong it a protection against spam. The only purpose of url input is to be empty and alway hidden.
PrestaShop/contactform@7800cec

I think that this input is type="text" because some bot doesn't fill hidden input.
It's a feature that was introduced in 2018, so I'm not sure if it's still useful because bots are smarter now.

@Hlavtox What do you think? Is it an obsolete way of preventing spam, so that we can set the input to type="hidden", or do we need to keep it as type="text"?

[Hlavtox]

@tblivet @ga-devfront Guys, any idea why it was there? Maybe there will be some evidence in git blame of classic theme.

[tblivet]

Hi @Hlavtox, this was already fixed but on the improvement branch : 64280d2

[ps-jarvis]

This pull request seems to contain new translation strings. I have summarized them below to ease up review:

• Shop.Theme.Customeraccount
  • Tracking

(Note: this is an automated message, but answering it will reach a real human)

[bibips]

Thank you, @tblivet. I updated the PR.

[bibips]

The waiting for wording label is incorrect... no translation string was added with this branch.
Could someone please remove this label ?

[paulnoelcholot]

Hello @bibips,

I tested your PR and it's good for me!

Thanks!