Skip to content

feat: add carrier name under each product on order history page#804

Merged
tblivet merged 14 commits intoPrestaShop:developfrom
Nakahiru:feature/order-history-multi-shipment
Dec 5, 2025
Merged

feat: add carrier name under each product on order history page#804
tblivet merged 14 commits intoPrestaShop:developfrom
Nakahiru:feature/order-history-multi-shipment

Conversation

@Nakahiru
Copy link
Contributor

@Nakahiru Nakahiru commented Nov 5, 2025

This pull request is implementing changes made here. When the feature flag improved shipment is enabled. If the order contains multiple shipment, we will display under each product name on the order history page, the carrier that handle this product.

Questions Answers
Type? new feature
BC breaks? no
Deprecations? no
Fixed ticket? -
Sponsor company -
How to test?

@ps-jarvis
Copy link

Hello @Nakahiru!

This is your first pull request on hummingbird repository of the PrestaShop project.

Thank you, and welcome to this Open Source community!

@github-project-automation github-project-automation bot moved this to Ready for review in PR Dashboard Nov 5, 2025
Copy link
Contributor

@ga-devfront ga-devfront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you got a closing tag missing

@ps-jarvis ps-jarvis moved this from Ready for review to Waiting for author in PR Dashboard Nov 5, 2025
Copy link
Contributor

@tblivet tblivet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need some changes

@ga-devfront ga-devfront changed the base branch from improvements to develop November 7, 2025 15:33
@ps-jarvis
Copy link

ps-jarvis commented Nov 7, 2025

This pull request seems to contain new translation strings. I have summarized them below to ease up review:

  • Shop.Theme.Customeraccount
    • Shipment tracking details
    • Products details
    • Order totals
  • Shop.Theme.Global
    • Virtual product(s): No delivery service
  • Shop.Theme.Catalog
    • %label%
    • Select
    • Available quantity to return:
    • Select quantity to return
    • Returned
    • Products details
    • Select product to return
    • Select all products
    • Order totals
  • Shop.Forms.Labels
    • Return notes

(Note: this is an automated message, but answering it will reach a real human)

tblivet
tblivet previously approved these changes Nov 7, 2025
ga-devfront
ga-devfront previously approved these changes Nov 7, 2025
@Nakahiru Nakahiru force-pushed the feature/order-history-multi-shipment branch from 1759b96 to 1634baa Compare November 27, 2025 09:35
Copy link
Contributor

@tblivet tblivet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nakahiru, I leave some suggestions 👍
And you should add a mention on virtual product like : Virtual product(s): No delivery service like we have on order-confirmation page !

Copy link
Contributor

@tblivet tblivet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions !

Nakahiru and others added 4 commits November 28, 2025 11:59
Co-authored-by: Blivet Thibault <110676325+tblivet@users.noreply.github.com>
Co-authored-by: Blivet Thibault <110676325+tblivet@users.noreply.github.com>
Co-authored-by: Blivet Thibault <110676325+tblivet@users.noreply.github.com>
Co-authored-by: Blivet Thibault <110676325+tblivet@users.noreply.github.com>
Copy link

@AureRita AureRita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Nakahiru

Thank you for your PR, I tested it and it seems to works as you can see :

Capture d’écran du 2025-11-12 11-52-35

Because the PR seems to works as expected, It's QA ✔️

Thank you

@tblivet tblivet merged commit 22ff3fa into PrestaShop:develop Dec 5, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from To be tested to Merged in PR Dashboard Dec 5, 2025
@ps-jarvis
Copy link

PR merged, well done!

Message to @PrestaShop/committers: do not forget to milestone it before the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants