Adding a red asterisk to the required checkboxes#823
Conversation
|
Hello @mgielecinski! This is your first pull request on hummingbird repository of the PrestaShop project. Thank you, and welcome to this Open Source community! |
tblivet
left a comment
tblivet
left a comment
There was a problem hiding this comment.
Hi @mgielecinski, thanks for your contribution 👍
You'll find a small suggestion to make it cleaner in terms of architecture.
| .form-check-label { | ||
| &.required { | ||
| &::before { | ||
| color: var(--bs-danger); | ||
| content: "*" / " "; | ||
| } | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
This code should be moved into a new file to match Bootstrap’s architecture.
I think it should be placed inside a new src/scss/bootstrap/components/_form-check.scss file.
$component-name: form-check-label;
.#{$component-name} {
&.required {
&::before {
color: var(--bs-danger);
content: "*" / " ";
}
}
}
|
Right, thanks @tblivet for the tip. I applied your suggestions and move code to new scss file. |
| content: "*" / " "; | ||
| } | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
Thank you for the modification 🙏
Don't forget to add a blank line at the end of the _form-check.scss file.
Then it's good for me 👍
tblivet
left a comment
tblivet
left a comment
There was a problem hiding this comment.
@mgielecinski Thanks for the lint 😀
|
PR merged, well done! Message to @PrestaShop/committers: do not forget to milestone it before the merge. |
5 participants
Before
After
