Skip to content

Fix small a11y fixes #831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tblivet merged 2 commits into from
Nov 24, 2025
Merged

Fix small a11y fixes #831

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f07f6d6
feat: add label for a11y
tblivet Nov 21, 2025
2138212
fix: missing type to prevent bad submit
tblivet Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions modules/ps_customersignin/ps_customersignin.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@
href="{$urls.pages.authentication}?back={$urls.current_url|urlencode}"
class="header-block__action-btn"
rel="nofollow"
aria-label="{l s='Sign in' d='Shop.Theme.Actions'}"
>
<i class="material-icons header-block__icon" aria-hidden="true">&#xE853;</i>
<span class="d-none d-md-inline header-block__title">
Expand Down
2 changes: 1 addition & 1 deletion templates/checkout/_partials/steps/addresses.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@
{/if}

<div class="buttons-wrapper buttons-wrapper--split buttons-wrapper--invert-mobile mt-3">
<button class="btn btn-outline-primary js-back" data-step="checkout-personal-information-step">
<button class="btn btn-outline-primary js-back" type="button" data-step="checkout-personal-information-step">
<i class="material-icons rtl-flip" aria-hidden="true">&#xE5C4;</i>
{l s='Back to Personal Information' d='Shop.Theme.Actions'}
</button>
Expand Down
2 changes: 1 addition & 1 deletion templates/checkout/_partials/steps/payment.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@
{/if}

<div class="buttons-wrapper buttons-wrapper--split buttons-wrapper--invert-mobile mt-3">
<button class="btn btn-outline-primary js-back" data-step="checkout-delivery-step">
<button class="btn btn-outline-primary js-back" type="button" data-step="checkout-delivery-step">
<div class="material-icons rtl-flip" aria-hidden="true">&#xE5C4;</div>
{l s='Back to Shipping' d='Shop.Theme.Actions'}
</button>
Expand Down
2 changes: 1 addition & 1 deletion templates/checkout/_partials/steps/shipping.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
</div>

<div class="buttons-wrapper buttons-wrapper--split buttons-wrapper--invert-mobile mt-3">
<button class="btn btn-outline-primary w-100 w-md-auto mb-3 mb-md-0 js-back" data-step="checkout-addresses-step">
<button class="btn btn-outline-primary w-100 w-md-auto mb-3 mb-md-0 js-back" type="button" data-step="checkout-addresses-step">
<div class="material-icons rtl-flip" aria-hidden="true">&#xE5C4;</div>
{l s='Back to Addresses' d='Shop.Theme.Actions'}
</button>
Expand Down