Small fixes related to the global Hummingbird theme QA review#832
Merged
tblivet merged 4 commits intoPrestaShop:developfrom Nov 25, 2025
Merged
Small fixes related to the global Hummingbird theme QA review#832tblivet merged 4 commits intoPrestaShop:developfrom
tblivet merged 4 commits intoPrestaShop:developfrom
Conversation
Contributor
tblivet
commented
Nov 24, 2025
tblivet
commented
| Questions | Answers |
|---|---|
| Description? | Small fixes related to the global Hummingbird theme QA review |
| Type? | bug fix |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | -- |
| Sponsor company | @PrestaShopCorp |
| How to test? | -- |
ga-devfront
previously approved these changes
Nov 24, 2025
ga-devfront
approved these changes
Nov 25, 2025
AureRita
approved these changes
Nov 25, 2025
AureRita
left a comment
AureRita
left a comment
There was a problem hiding this comment.
Hi @tblivet
Thank you for your PR, I tested it and it correct all the divers issue seen, as you can see :
Capture.video.du.2025-11-25.12-12-13.mp4
and the screen reader correctly read the part for the number of product contain in your cart
Tested on :
9.0.1-classic
9.1.0 (develop
Because the PR seems to works as expected, It's QA ✔️
Thank you
|
PR merged, well done! Message to @PrestaShop/committers: do not forget to milestone it before the merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.