Skip to content

Prevent adding invalid values to quantity inputs#835

Merged
tblivet merged 1 commit intoPrestaShop:developfrom
tblivet:fix/quickview-qty
Dec 3, 2025
Merged

Prevent adding invalid values to quantity inputs#835
tblivet merged 1 commit intoPrestaShop:developfrom
tblivet:fix/quickview-qty

Conversation

@tblivet
Copy link
Contributor

@tblivet tblivet commented Dec 3, 2025

Questions Answers
Description? Prevent adding invalid values like "-" inside quantity inputs
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? PrestaShop/PrestaShop#35219
Sponsor company @PrestaShopCorp
How to test? Follow the issue and also check the behaviour of all quantity selectors, such as those on the product list, product page, and cart page.

@tblivet tblivet requested a review from ga-devfront December 3, 2025 08:53
@github-project-automation github-project-automation bot moved this to Ready for review in PR Dashboard Dec 3, 2025
@ingridusta ingridusta self-assigned this Dec 3, 2025
@ps-jarvis ps-jarvis moved this from Ready for review to To be tested in PR Dashboard Dec 3, 2025
Copy link

@ingridusta ingridusta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tblivet,

I tested your PR.

On those elements, filling qqty with invalid values (as letter, symbols) is not possible anymore :

  • Featured products
  • Quick view modal
  • Product page
  • Category page
  • Cart page
Capture d’écran 2025-12-03 à 12 11 13 Capture d’écran 2025-12-03 à 12 10 38 Capture d’écran 2025-12-03 à 12 10 05 Capture d’écran 2025-12-03 à 12 09 31 Capture d’écran 2025-12-03 à 12 08 59

It's QA approved ✌️✅

@ingridusta ingridusta removed their assignment Dec 3, 2025
@tblivet tblivet merged commit fcba1db into PrestaShop:develop Dec 3, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from To be tested to Merged in PR Dashboard Dec 3, 2025
@ps-jarvis ps-jarvis moved this from Merged to To be tested in PR Dashboard Dec 3, 2025
@ps-jarvis
Copy link

PR merged, well done!

Message to @PrestaShop/committers: do not forget to milestone it before the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants