Skip to content

[IMPROVEMENT] Add debouncing to quantity selection on the product page #844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tblivet merged 2 commits into from
Dec 9, 2025
Merged

[IMPROVEMENT] Add debouncing to quantity selection on the product page #844

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22ee6cb
feat: triggerEmit on input event and add debounce
tblivet Dec 8, 2025
23e7cd8
fix: review
tblivet Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/js/product.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
*/

import SelectorsMap from '@constants/selectors-map';
import debounce from '@helpers/debounce';

type ProductSlideEvent = Event & {to: number};

Expand Down Expand Up @@ -59,7 +60,7 @@ export default () => {

if (quantityInput && incrementButton && decrementButton) {
// Function to trigger emit
const triggerEmit = () => {
const triggerEmit = async () => {
const inputValue = parseInt(quantityInput.value, 10);
const minQuantity = getMinValue(quantityInput);

Expand All @@ -75,6 +76,8 @@ export default () => {
});
};

const debouncedTriggerEmit = debounce(triggerEmit, 500);

quantityInput.addEventListener('input', (event: Event) => {
const input = event.target as HTMLInputElement;
const minQuantity = getMinValue(input);
Expand All @@ -85,7 +88,7 @@ export default () => {
input.value = clampedValue.toString();
}

triggerEmit();
debouncedTriggerEmit();
});

quantityInput.addEventListener('blur', () => {
Expand Down