Fix incomplete condition on order detail and improve shipment flag#849
Merged
tblivet merged 1 commit intoPrestaShop:developfrom Dec 9, 2025
Merged
Fix incomplete condition on order detail and improve shipment flag#849tblivet merged 1 commit intoPrestaShop:developfrom
tblivet merged 1 commit intoPrestaShop:developfrom
Conversation
Contributor
tblivet
commented
Dec 9, 2025
tblivet
commented
| Questions | Answers |
|---|---|
| Description? | Fix incomplete condition on order detail and improve shipment flag |
| Type? | bug fix |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | #847 |
| Sponsor company | @PrestaShopCorp |
| How to test? | Refer to the issue |
ga-devfront
approved these changes
Dec 9, 2025
Closed
2 tasks
ingridusta
approved these changes
Dec 9, 2025
ingridusta
left a comment
ingridusta
left a comment
There was a problem hiding this comment.
Hi @tblivet,
Your PR is tested and works perfectly ✨
"Carrier" line is no more displayed on virtual product only orders :
No regression on orders with physical products :
And no regression on Classic theme :
It's QA approved 👍 ✅
|
PR merged, well done! Message to @PrestaShop/committers: do not forget to milestone it before the merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.