Skip to content

Prevent duplicate product removal on fast double-click #859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tblivet merged 1 commit into from
Dec 12, 2025
Merged

Prevent duplicate product removal on fast double-click #859

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/js/components/useQuantityInput.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,11 @@ const updateQuantity = async (qtyInputGroup: Theme.QuantityInput.InputGroup, cha
const baseValue = Number(qtyInput.getAttribute('value'));
const quantity = targetValue - baseValue;

// Skip update if value is 0 and min is 1 (item is being removed)
if (targetValue === 0 && qtyInput.getAttribute('min') === '1') {
return;
}

if (isValidInputNum(targetValue) && quantity !== 0) {
const requestUrl = qtyInput.dataset.updateUrl;

Expand Down
23 changes: 15 additions & 8 deletions src/js/pages/cart.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,18 @@ import {isHTMLElement} from '@helpers/typeguards';
import handleCartAction from '@js/components/UseHandleCartAction';
import SelectorsMap from '@constants/selectors-map';
import {state, availableLastUpdateAction} from '@js/state';
import debounce from '@helpers/debounce';

export default () => {
// Debounced function to trigger remove action, preventing multiple rapid clicks
const debouncedRemoveAction = debounce(async (...args) => {
const removeButton = args[0] as HTMLElement;

if (removeButton) {
removeButton.click();
}
}, 500);

// Event delegation for voucher code clicks
const handleVoucherClick = (event: Event) => {
event.stopPropagation();
Expand Down Expand Up @@ -50,15 +60,12 @@ export default () => {
) as HTMLElement | null;

if (targetValue) {
if (eventTarget.classList.contains('js-increment-button')) {
if (targetValue.dataset.mode === 'confirmation' && Number(targetValue.value) < 1) {
removeButton?.click();
}
}
const isDecrement = eventTarget.classList.contains('js-decrement-button');

if (eventTarget.classList.contains('js-decrement-button')) {
if (targetValue.value === '0' && targetValue.getAttribute('min') === '1') {
removeButton?.click();
// Debounce remove action to prevent multiple rapid clicks
if (isDecrement && targetValue.value === '0' && targetValue.getAttribute('min') === '1') {
if (removeButton) {
debouncedRemoveAction(removeButton);
}
}
}
Expand Down