Refactor emailalerts and psgdpr modules#903
Merged
tblivet merged 16 commits intoPrestaShop:developfrom Jan 21, 2026
Merged
Conversation
Contributor
tblivet
commented
Jan 19, 2026
tblivet
commented
| Questions | Answers |
|---|---|
| Description? | Refactor emailalerts and psgdpr modules |
| Type? | improvement |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | -- |
| Sponsor company | @PrestaShopCorp |
| How to test? | -- |
tblivet
force-pushed
the
feat/mail-alert-and-config
branch
from
ab81887 to
3bf1d91
Compare
ga-devfront
reviewed
Jan 20, 2026
src/js/modules/psgdpr.ts
Outdated
Comment on lines
+81
to
+85
| id_customer: data.idCustomer, | ||
| customer_token: data.customerToken, | ||
| id_guest: data.idGuest, | ||
| guest_token: data.guestToken, | ||
| id_module: data.moduleId, |
Contributor
There was a problem hiding this comment.
..data
Suggested change
| id_customer: data.idCustomer, | |
| customer_token: data.customerToken, | |
| id_guest: data.idGuest, | |
| guest_token: data.guestToken, | |
| id_module: data.moduleId, | |
| ...data, |
Comment on lines
+22
to
+27
| "moduleId": "{$psgdpr_id_module|escape:'htmlall':'UTF-8'}", | ||
| "frontController": "{$psgdpr_front_controller|escape:'htmlall':'UTF-8'}", | ||
| "idCustomer": "{$psgdpr_id_customer|escape:'htmlall':'UTF-8'}", | ||
| "customerToken": "{$psgdpr_customer_token|escape:'htmlall':'UTF-8'}", | ||
| "idGuest": "{$psgdpr_id_guest|escape:'htmlall':'UTF-8'}", | ||
| "guestToken": "{$psgdpr_guest_token|escape:'htmlall':'UTF-8'}" |
Contributor
There was a problem hiding this comment.
Suggested change
| "moduleId": "{$psgdpr_id_module|escape:'htmlall':'UTF-8'}", | |
| "frontController": "{$psgdpr_front_controller|escape:'htmlall':'UTF-8'}", | |
| "idCustomer": "{$psgdpr_id_customer|escape:'htmlall':'UTF-8'}", | |
| "customerToken": "{$psgdpr_customer_token|escape:'htmlall':'UTF-8'}", | |
| "idGuest": "{$psgdpr_id_guest|escape:'htmlall':'UTF-8'}", | |
| "guestToken": "{$psgdpr_guest_token|escape:'htmlall':'UTF-8'}" | |
| "id_module": "{$psgdpr_id_module|escape:'htmlall':'UTF-8'}", | |
| "front_controller": "{$psgdpr_front_controller|escape:'htmlall':'UTF-8'}", | |
| "id_customer": "{$psgdpr_id_customer|escape:'htmlall':'UTF-8'}", | |
| "customer_token": "{$psgdpr_customer_token|escape:'htmlall':'UTF-8'}", | |
| "id_guest": "{$psgdpr_id_guest|escape:'htmlall':'UTF-8'}", | |
| "guest_token": "{$psgdpr_guest_token|escape:'htmlall':'UTF-8'}" |
ga-devfront
approved these changes
Jan 20, 2026
ingridusta
approved these changes
Jan 21, 2026
ingridusta
left a comment
ingridusta
left a comment
There was a problem hiding this comment.
Hi @tblivet,
Your PR is tested and works as expected.
- Not signed in and psgdpr disabled :
- Signed in and psgdpr disabled :
Enregistrement.de.l.ecran.2026-01-21.a.14.14.10.mov
- Not signed in and psgdpr enabled :
- Signed in and psgdpr enabled :
- Other impact with psgdpr enabled :
Account creation form :
Customer account area :
Newsletter subscription :
Product Comments :
Contact form :
It's QA approved ✅ !
|
PR merged, well done! Message to @PrestaShop/committers: do not forget to milestone it before the merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.