Skip to content

Converted UPC to gtin13 in product schema #916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tblivet merged 6 commits into from
Jan 29, 2026
Merged

Converted UPC to gtin13 in product schema #916

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
df005c3
fix upc code in gtin13
mgielecinski Jan 27, 2026
7514093
apply review
mgielecinski Jan 29, 2026
7649d8a
apply second review
mgielecinski Jan 29, 2026
51723a2
remove duplicated name in offer
mgielecinski Jan 29, 2026
8e0e80c
remove old if block close
mgielecinski Jan 29, 2026
52e578e
change gtin13 to gtin
mgielecinski Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions templates/_partials/microdata/product-jsonld.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"sku": "{if $product.reference}{$product.reference}{else}{$product.id}{/if}",
"mpn": "{if $product.mpn}{$product.mpn}{elseif $product.reference}{$product.reference}{else}{$product.id}{/if}"
{if $product.ean13},"gtin13": "{$product.ean13}"
{elseif $product.upc},"gtin13": "{$product.upc}"
{elseif $product.upc},"gtin12": "{$product.upc}"
{/if}
Copy link
Contributor

@tblivet tblivet Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mgielecinski Thanks for the changes, but you forgot to remove a {/if}.

Suggested change
{/if}

Copy link
Contributor Author

@mgielecinski mgielecinski Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohhh.. 2 Fast 2 Furious 😆

{if isset($product_manufacturer) && $product_manufacturer->name},
"brand": {
Expand Down Expand Up @@ -80,7 +80,7 @@
{/if}
"sku": "{if $product.reference}{$product.reference}{else}{$product.id}{/if}",
"mpn": "{if $product.mpn}{$product.mpn}{elseif $product.reference}{$product.reference}{else}{$product.id}{/if}",
{if $product.ean13}"gtin13": "{$product.ean13}",{elseif $product.upc}"gtin13": "0{$product.upc}",{/if}
{if $product.ean13}"gtin13": "{$product.ean13}",{elseif $product.upc}"gtin12": "{$product.upc}",{/if}
Copy link
Contributor

@tblivet tblivet Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I hadn’t noticed that the code was in two different places. I believe sku, mpn, ean13, and upc inside the Offers type can be removed, as they are duplicates.

{if !empty($product.show_condition) && !empty($product.condition)}"itemCondition": "{$product.condition.schema_url}",{/if}
"availability": "{$product.seo_availability}",
"seller": {
Expand Down